Skip to content

Fix Code Quality Findings #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Morgy93 merged 2 commits into from
Jan 12, 2026
Merged

Fix Code Quality Findings #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
958210d
[chore] ✏️ docs: update changelog formatting and links
Morgy93 Jan 12, 2026
102007c
🔧 test: improve assertions in DdevUtils test suite
Morgy93 Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,11 @@ All notable changes to this project will be documented in this file. This projec

## [0.5.0](https://github.com/OpenForgeProject/vscode-ddev-phpstan/compare/v0.4.2...v0.5.0) (2026-01-12)


### Features

* update release management ([6c5c5ac](https://github.com/OpenForgeProject/vscode-ddev-phpstan/commit/6c5c5acc4a8609bb6dd3262c21a771abef182f93))
* **Release Management**: Refined release workflow with conditional execution and updated token configuration ([6c5c5ac](https://github.com/OpenForgeProject/vscode-ddev-phpstan/commit/6c5c5acc4a8609bb6dd3262c21a771abef182f93))

## [0.4.2] - 2025-10-01
## [0.4.2](https://github.com/OpenForgeProject/vscode-ddev-phpstan/compare/v0.4.1...v0.4.2) (2025-10-01)

### Changed

Expand All @@ -32,7 +31,7 @@ All notable changes to this project will be documented in this file. This projec
- Custom changelog parsing for meaningful release notes
- Maintained compatibility across all supported platforms (macOS, Ubuntu, Windows)

## [0.4.1] - 2025-10-01
## [0.4.1](https://github.com/OpenForgeProject/vscode-ddev-phpstan/compare/v0.4.0...v0.4.1) (2025-10-01)

### Added

Expand All @@ -56,7 +55,7 @@ All notable changes to this project will be documented in this file. This projec
- Maintained full functionality while reducing package size
- GitHub Actions ready for automated marketplace publishing

## [0.4.0] - 2025-09-30
## [0.4.0](https://github.com/OpenForgeProject/vscode-ddev-phpstan/compare/v0.3.0...v0.4.0) (2025-09-30)

### Changed

Expand All @@ -81,7 +80,7 @@ All notable changes to this project will be documented in this file. This projec
- Enhanced type annotations for esbuild plugins and configuration objects
- Maintained full backward compatibility with existing functionality

## [0.3.0] - 2025-09-30
## [0.3.0](https://github.com/OpenForgeProject/vscode-ddev-phpstan/compare/v0.2.0...v0.3.0) (2025-09-30)

### Updated

Expand Down Expand Up @@ -110,7 +109,7 @@ All notable changes to this project will be documented in this file. This projec
- Enhanced build performance with latest esbuild version
- Modernized GitHub Actions for better CI/CD reliability

## [0.2.0] - 2025-09-30
## [0.2.0](https://github.com/OpenForgeProject/vscode-ddev-phpstan/compare/v0.1.0...v0.2.0) (2025-09-30)

### Added

Expand Down Expand Up @@ -143,7 +142,7 @@ All notable changes to this project will be documented in this file. This projec
- Multi-platform compatibility testing
- Security vulnerability scanning

## [0.1.0] - 2025-09-30
## [0.1.0](https://github.com/OpenForgeProject/vscode-ddev-phpstan/releases/tag/v0.1.0) (2025-09-30)

### Added

Expand Down
9 changes: 5 additions & 4 deletions src/test/ddev-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ suite('DdevUtils Test Suite', () => {
const result = DdevUtils.hasDdevProject('/test/workspace');

assert.strictEqual(result, true);
assert.strictEqual(existsSyncStub.calledOnce, true);
sinon.assert.calledOnce(existsSyncStub);
});

test('hasDdevProject returns false when .ddev/config.yaml does not exist', () => {
Expand All @@ -52,6 +52,7 @@ suite('DdevUtils Test Suite', () => {
const result = DdevUtils.hasDdevProject('/test/workspace');

assert.strictEqual(result, false);
sinon.assert.calledOnce(existsSyncStub);
});

test('isDdevRunning returns true when DDEV container is running', () => {
Expand Down Expand Up @@ -105,7 +106,7 @@ suite('DdevUtils Test Suite', () => {
const result = DdevUtils.validateDdevTool('phpstan', '/test/workspace');

assert.strictEqual(result.isValid, true);
assert.strictEqual(result.errorType, undefined);
assert.ok(result.errorType === undefined);
});

test('validateDdevTool returns error message for DDEV issues', () => {
Expand All @@ -120,7 +121,7 @@ suite('DdevUtils Test Suite', () => {

assert.strictEqual(result.isValid, false);
assert.strictEqual(result.errorType, 'ddev-not-running');
assert.ok(result.userMessage?.includes('appears to be stopped'));
assert.ok(result.userMessage && result.userMessage.includes('appears to be stopped'));
});

test('validateDdevTool returns tool not found message when tool is missing', () => {
Expand All @@ -145,7 +146,7 @@ suite('DdevUtils Test Suite', () => {
const result = DdevUtils.execDdev(['phpstan', 'analyze'], '/test/workspace');

assert.strictEqual(result, 'output');
assert.strictEqual(spawnSyncStub.calledOnce, true);
sinon.assert.calledOnce(spawnSyncStub);
const callArgs = spawnSyncStub.firstCall.args;
assert.strictEqual(callArgs[0], 'ddev');
assert.deepStrictEqual(callArgs[1], ['exec', 'env', 'XDEBUG_MODE=off', 'phpstan', 'analyze']);
Expand Down
Loading