fix: improve theme selection and validation in TokensCommand #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dermatz
force-pushed
the
fix/token-command-complexity
branch
from
9758782 to
18821f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor TokensCommand to reduce complexity
Extracted the 126-line
executeCommand()method into 6 focused private methods following Single Responsibility Principle:selectTheme()- Theme selection logicvalidateHyvaTheme()- Theme path & Hyvä validationvalidateTailwindDirectory()- Tailwind/node_modules checksgenerateTokens()- npx hyva-tokens executionhandleOutputFile()- Output handling & user feedbackcopyToVarGenerated()- Vendor theme file operationsMain method reduced from 126 to 28 lines, improving readability and maintainability. No functional changes.