Add mageforge:hyva:tokens command for Hyvä design token generation

CHANGELOG.md

@@ -6,8 +6,10 @@ All notable changes to this project will be documented in this file.
 
 ## UNRELEASED
 
+
 ### Added
 
+- feat: add `mageforge:theme:tokens` command to generate Hyvä design tokens from design.tokens.json or hyva.config.json
 - feat: add `mageforge:hyva:compatibility:check` command to add a Hyvä compatibility checker
   - Scans Magento modules for Hyvä theme compatibility issues
   - Detects RequireJS, Knockout.js, jQuery, and UI Components usage

README.md

@@ -37,7 +37,8 @@ Please ensure that your Magento installation meets this requirement before insta
 | `mageforge:theme:list`     | Lists all available themes                                | `m:t:l`                   |
 | `mageforge:theme:build`    | Builds selected themes (CSS/TailwindCSS)                  | `m:t:b`, `frontend:build` |
 | `mageforge:theme:watch`    | Starts watch mode for theme development                   | `m:t:w`, `frontend:watch` |
-| `mageforge:static:clean`   | Clean static files, cache and generated files for a theme | `frontend:clean`          |
+| `mageforge:hyva:tokens`    | Generate Hyvä design tokens (Hyvä themes only)            | `m:h:t`                   |
+| `mageforge:static:clean`   | Clean static files, cache and generated files for a theme | `m:st:c`,`frontend:clean` |
 
 ---
 
@@ -79,7 +80,15 @@ Please ensure that your Magento installation meets this requirement before insta
    bin/magento mageforge:theme:watch <theme-code>
    ```
 
-4. Enjoy automatic CSS rebuilding you work on your theme files!
+4. Generate Hyvä design tokens (for Hyvä themes):
+
+   ```bash
+   bin/magento mageforge:hyva:tokens <theme-code>
+   ```
+
+   This creates a `generated/hyva-tokens.css` file from your design tokens configuration.
+
+5. Enjoy automatic CSS rebuilding as you work on your theme files!
 
 ## Additional Documentation
 

docs/commands.md

@@ -101,16 +101,19 @@ bin/magento mageforge:theme:watch [--theme=THEME]
 **File**: `/src/Console/Command/Static/CleanCommand.php`
 
 **Dependencies**:
+
 - `Filesystem` - Magento filesystem component for file operations
 - `ThemeList` - Service to retrieve theme information
 - `ThemePath` - Service to resolve theme paths
 
 **Usage**:
+
 ```bash
 bin/magento mageforge:static:clean [<themename>]
 ```
 
 **Implementation Details**:
+
 - If no theme name is provided:
   - In interactive terminals, displays an interactive prompt to select the theme to clean
   - In non-interactive environments, prints the list of available themes and exits, requiring an explicit theme name
@@ -157,7 +160,7 @@ bin/magento mageforge:system:check
 
 ---
 
-### 6. VersionCommand (`mageforge:version`)
+### 5. VersionCommand (`mageforge:version`)
 
 **Purpose**: Displays the current and latest version of the MageForge module.
 
@@ -308,6 +311,80 @@ _PHTML Files (.phtml)_:
 
 ---
 
+### 7. TokensCommand (`mageforge:hyva:tokens`)
+
+**Purpose**: Generates Hyvä design tokens from design.tokens.json or hyva.config.json configuration files.
+
+**File**: `/src/Console/Command/Theme/TokensCommand.php`
+
+**Dependencies**:
+
+- `ThemeList` - Service to retrieve theme information
+- `ThemePath` - Service to resolve theme paths
+- `BuilderPool` - Service to verify Hyvä theme type
+- `File` - Filesystem driver for directory checks
+- `Shell` - Shell command executor
+
+**Usage**:
+
+```bash
+bin/magento mageforge:hyva:tokens [<themeCode>]
+```
+
+**Aliases**:
+
+- `m:h:t`
+
+**Arguments**:
+
+- `themeCode` (optional) - Theme code in format Vendor/theme
+
+**Examples**:
+
+```bash
+# Interactive mode - select theme from list
+bin/magento m:h:t
+
+# Direct execution
+bin/magento mageforge:hyva:tokens Hyva/default
+```
+
+**Implementation Details**:
+
+- If no theme code is provided, displays an interactive prompt to select a Hyvä theme
+- Validates that the theme is installed and is a Hyvä theme
+- Checks if the theme has been built (node_modules exists)
+- Changes to the theme's `web/tailwind` directory
+- Executes `npx hyva-tokens` to generate design tokens
+- For themes in `app/design/frontend/`:
+  - Generates tokens in `web/tailwind/generated/hyva-tokens.css`
+- For vendor themes (in `vendor/` directory):
+  - Generates tokens in `web/tailwind/generated/hyva-tokens.css` first
+  - Copies the generated file to `var/generated/hyva-token/{ThemeCode}/hyva-tokens.css`
+  - Displays a note informing that tokens were saved to var/generated location
+- Returns success status code or error message
+
+**Requirements**:
+
+- Theme must be a Hyvä theme
+- Theme must be built first (`mageforge:theme:build`)
+- Node.js and npm must be available
+- `hyva-tokens` package must be installed (via theme build)
+
+**Output Locations**:
+
+- **Custom themes** (app/design): `{theme-path}/web/tailwind/generated/hyva-tokens.css`
+- **Vendor themes** (vendor/): `var/generated/hyva-token/{ThemeCode}/hyva-tokens.css`
+
+**Error Handling**:
+
+- Returns error if theme is not installed
+- Returns error if theme is not a Hyvä theme
+- Returns warning if node_modules not found (build required)
+- Returns error if tailwind directory doesn't exist
+
+---
+
 ## Command Services
 
 The commands rely on several services for their functionality:

src/Console/Command/Theme/TokensCommand.php

@@ -0,0 +1,164 @@
+<?php
+
+declare(strict_types=1);
+
+namespace OpenForgeProject\MageForge\Console\Command\Theme;
+
+use Laravel\Prompts\SelectPrompt;
+use Magento\Framework\Console\Cli;
+use Magento\Framework\Filesystem\Driver\File;
+use Magento\Framework\Shell;
+use OpenForgeProject\MageForge\Console\Command\AbstractCommand;
+use OpenForgeProject\MageForge\Model\ThemeList;
+use OpenForgeProject\MageForge\Model\ThemePath;
+use OpenForgeProject\MageForge\Service\ThemeBuilder\BuilderPool;
+use Symfony\Component\Console\Input\InputArgument;
+use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\OutputInterface;
+
+/**
+ * Command for generating Hyvä design tokens
+ */
+class TokensCommand extends AbstractCommand
+{
+    /**
+     * @param ThemeList $themeList
+     * @param ThemePath $themePath
+     * @param BuilderPool $builderPool
+     * @param File $fileDriver
+     * @param Shell $shell
+     */
+    public function __construct(
+        private readonly ThemeList $themeList,
+        private readonly ThemePath $themePath,
+        private readonly BuilderPool $builderPool,
+        private readonly File $fileDriver,
+        private readonly Shell $shell,
+    ) {
+        parent::__construct();
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function configure(): void
+    {
+        $this->setName($this->getCommandName('hyva', 'tokens'))
+            ->setAliases(['m:h:t'])
+            ->setDescription('Generate Hyvä design tokens from design.tokens.json or hyva.config.json')
+            ->addArgument(
+                'themeCode',
+                InputArgument::OPTIONAL,
+                'Theme code to generate tokens for (format: Vendor/theme)'
+            );
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    protected function executeCommand(InputInterface $input, OutputInterface $output): int
+    {
+        $themeCode = $input->getArgument('themeCode');
+        $isVerbose = $this->isVerbose($output);
+
+        if (empty($themeCode)) {
+            $themes = $this->themeList->getAllThemes();
+            $options = array_map(fn($theme) => $theme->getCode(), $themes);
+
+            $themeCodePrompt = new SelectPrompt(
+                label: 'Select theme to generate tokens for',
+                options: $options,
+                scroll: 10,
+                hint: 'Arrow keys to navigate, Enter to confirm',
+            );
+
+            try {
+                $themeCode = $themeCodePrompt->prompt();
+                \Laravel\Prompts\Prompt::terminal()->restoreTty();
+            } catch (\Exception $e) {
+                $this->io->error('Interactive mode failed: ' . $e->getMessage());
+                return Cli::RETURN_FAILURE;
+            }
+        }
+
+        $themePath = $this->themePath->getPath($themeCode);
+        if ($themePath === null) {
+            $this->io->error("Theme $themeCode is not installed.");
+            return Cli::RETURN_FAILURE;
+        }
+
+        // Check if this is a Hyvä theme
+        $builder = $this->builderPool->getBuilder($themePath);
+        if ($builder === null || $builder->getName() !== 'HyvaThemes') {
+            $this->io->error("Theme $themeCode is not a Hyvä theme. This command only works with Hyvä themes.");
+            return Cli::RETURN_FAILURE;
+        }
+
+        $tailwindPath = rtrim($themePath, '/') . '/web/tailwind';
+        if (!$this->fileDriver->isDirectory($tailwindPath)) {
+            $this->io->error("Tailwind directory not found in: $tailwindPath");
+            return Cli::RETURN_FAILURE;
+        }
+
+        // Check if node_modules exists
+        if (!$this->fileDriver->isDirectory($tailwindPath . '/node_modules')) {
+            $this->io->warning('Node modules not found. Please run: bin/magento mageforge:theme:build ' . $themeCode);
+            return Cli::RETURN_FAILURE;
+        }
+
+        if ($isVerbose) {
+            $this->io->section("Generating Hyvä design tokens for theme: $themeCode");
+            $this->io->text("Working directory: $tailwindPath");
+        }
+
+        // Change to tailwind directory and run npx hyva-tokens
+        $currentDir = getcwd();
+        chdir($tailwindPath);
+
+        try {
+            if ($isVerbose) {
+                $this->io->text('Running npx hyva-tokens...');
+            }
+
+            $this->shell->execute('npx hyva-tokens');
+
+            chdir($currentDir);
+
+            // Determine output path based on theme location
+            $isVendorTheme = str_contains($themePath, '/vendor/');
+            $sourceFilePath = $tailwindPath . '/generated/hyva-tokens.css';
+
+            if ($isVendorTheme) {
+                // Store in var/generated/hyva-token/{ThemeCode}/ for vendor themes
+                $varGeneratedPath = $currentDir . '/var/generated/hyva-token/' . str_replace('/', '/', $themeCode);
+
+                if (!$this->fileDriver->isDirectory($varGeneratedPath)) {
+                    $this->fileDriver->createDirectory($varGeneratedPath, 0755);
+                }
+
+                $generatedFilePath = $varGeneratedPath . '/hyva-tokens.css';
+
+                // Copy file to var/generated location
+                if ($this->fileDriver->isExists($sourceFilePath)) {
+                    $this->fileDriver->copy($sourceFilePath, $generatedFilePath);
+                }
+
+                $this->io->success('Hyvä design tokens generated successfully.');
+                $this->io->note('This is a vendor theme. Tokens have been saved to var/generated/hyva-token/ instead.');
+                $this->io->text('Generated file: ' . $generatedFilePath);
+            } else {
+                $generatedFilePath = $sourceFilePath;
+                $this->io->success('Hyvä design tokens generated successfully.');
+                $this->io->text('Generated file: ' . $generatedFilePath);
+            }
+
+            $this->io->newLine();
+
+            return Cli::RETURN_SUCCESS;
+        } catch (\Exception $e) {
+            chdir($currentDir);
+            $this->io->error('Failed to generate Hyvä design tokens: ' . $e->getMessage());
+            return Cli::RETURN_FAILURE;
+        }
+    }
+}

src/etc/di.xml

@@ -21,6 +21,8 @@
                               OpenForgeProject\MageForge\Console\Command\Static\CleanCommand</item>
                         <item name="mageforge_hyva_compatibility_check" xsi:type="object">
                               OpenForgeProject\MageForge\Console\Command\Hyva\CompatibilityCheckCommand</item>
+                        <item name="mageforge_theme_tokens" xsi:type="object">
+                              OpenForgeProject\MageForge\Console\Command\Theme\TokensCommand</item>
                   </argument>
             </arguments>
       </type>