Skip to content

Strip whitespace from varName in TypeExtends constructor#1576

Open
dodgex wants to merge 1 commit intoOpenFeign:masterfrom
dodgex:patch-1
Open

Strip whitespace from varName in TypeExtends constructor#1576
dodgex wants to merge 1 commit intoOpenFeign:masterfrom
dodgex:patch-1

Conversation

@dodgex
Copy link
Contributor

@dodgex dodgex commented Jan 30, 2026

This is a fix for some strange issue during code generation.

See Issue querydsl/querydsl#3747 in original querydsl repo as well as the related PR querydsl/querydsl#3596.

The linked PR has only partially been ported to OpenFeigen QueryDSL in #481.

Back then we worked arround this issue by refactoring the affected code, but now we had this issue again and remembered the comment that this was fixed in OpenFeign fork just to sadly find out, that it is still present here too. :(

But as the other repo is pretty much dead, I hope we can get this one merged here, and possibly even a timely release. :D

Thanks in advance.

@codecov
Copy link

codecov bot commented Jan 30, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (115ed29) to head (b9e4773).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../com/querydsl/codegen/utils/model/TypeExtends.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1576    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files         813     838    +25     
  Lines       31466   31795   +329     
  Branches     3614    3622     +8     
=======================================
- Misses      31466   31795   +329     
Flag Coverage Δ
cubrid 0.00% <0.00%> (?)
db2 0.00% <0.00%> (?)
embedded 0.00% <0.00%> (?)
examples 0.00% <0.00%> (?)
firebird 0.00% <0.00%> (?)
mongodb 0.00% <0.00%> (?)
mysql 0.00% <0.00%> (?)
oracle 0.00% <0.00%> (?)
postgresql 0.00% <0.00%> (?)
test 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant