Fix static ExecutorService ClassLoader leak in AsyncFeign#3277
Open
Fix static ExecutorService ClassLoader leak in AsyncFeign#3277
Conversation
…o fix ClassLoader leak (#3178) Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3178
LazyInitializedExecutorServicesingleton inAsyncFeignandCoroutineFeignwith a per-instance factory methodnewDefaultExecutorService()AsyncBuilder/CoroutineBuildernow creates its ownExecutorServiceinstead of sharing a JVM-wide static oneThe root cause was that the static
ExecutorServiceheld strong references to theContextClassLoaderof the first application that loaded the class. On redeployment, the old ClassLoader could never be garbage collected because the static executor's threads still referenced it.With this change, each builder gets its own cached thread pool. Since
newCachedThreadPoolreclaims idle threads after 60 seconds, threads from discarded feign clients will naturally clean up. Users who want explicit control can continue to provide their ownExecutorServicevia theclient()builder method.Test plan
AsyncFeignTest(52 tests) passes with no regressions🤖 Generated with Claude Code
@QiuYucheng2003 — you reported this issue, could you review this fix?