Merged
Conversation
Collaborator
|
Contributor
Author
|
I am getting the same error as issue #2725 and can't update / test the windows build. Would need some help with changes to windows specific files. |
Contributor
Author
Created a PR OpenFAST/openfast_toolbox#43 for required changes to OpenFAST_ToolBox. |
Contributor
Author
|
Also, I think we might need to modify the image in the documentation depicting super controller as a submodule. I can work on it but don't have the source image. |
Collaborator
|
I ran a quick check on the documentation. It doesn't build correctly at the moment. I'll make some edits and PR to your branch. |
When I merged the `OpenFAST/dev` in, I clobbered a change from PR OpenFAST#2746
8ad221e to
b91dd7e
Compare
4235ce2 to
ae055b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Remove supercontroller from FAST.Farm in favor of external tools like ROSCO's wind farm control capability and Wind Hybrid Open Controller
Impacted areas of the software
FAST.Farm
Test results, if applicable
FAST.Farm test
Release checklist (DRAFT will check-off when completed):
Compile executables for Windows buildsFAST_SFunc.mexw64OpenFAST-Simulink_x64.dllopenfast_x64.exeDISCON.dll