Open
Conversation
boring-cyborg
bot
added
Compiler
Collaborator
Author
|
Need to cope with async proc states. |
wixoaGit
requested changes
Feb 10, 2026
| @@ -0,0 +1,16 @@ | |||
| /datum/meep/proc/bar() | |||
| ASSERT(caller.caller.caller.name == "ihateithere") | |||
Member
There was a problem hiding this comment.
Should this not be "RunTest"?
Could also be using nameof(/proc/RunTest) for these asserts instead.
| /// </summary> | ||
| private void SetCaller() { | ||
| if (ProcState is null || _caller is not null) return; | ||
| if (ProcState.Thread.PeekStack(1) is not DMProcState dmProcState) return; |
Member
There was a problem hiding this comment.
Always passing an index of 1 is incorrect
| case "caller": | ||
| // TODO | ||
| value = DreamValue.Null; | ||
| SetCaller(); // sometimes ProcState is null in the constructor? |
Member
There was a problem hiding this comment.
Why wouldn't ProcState always be null in the constructor? It's not passed to the constructor or set in there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2203
This is admittedly a bit awful but the alternative is every single proccall storing its
ProcStateon the called proc even when nobody utilizes or cares aboutcaller.