Initial SoundQuery() implementation
#2485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
Client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wixoaGit
requested changes
Jan 7, 2026
added 2 commits
January 6, 2026 20:42
| public SoundData SoundData { | ||
| get { | ||
| _soundData.Offset = Source.Component.PlaybackPosition; | ||
| _soundData.Length = (float)audioSystem.GetAudioLength(Source.Component.FileName).TotalSeconds; |
Check warning
Code scanning / InspectCode
Use of obsolete symbol Warning
Collaborator
Author
There was a problem hiding this comment.
Electing to ignore this as converting a bunch of audio code to use sound specifiers is out of scope and GetAudioLength(SoundSpecifier) just calls this GetAudioLength(string) overload currently anyways.
ike709
commented
Jan 7, 2026
|
|
||
| var db = 20 * MathF.Log10(volume); // convert from DM volume (0-100) to OpenAL volume (db) | ||
| var source = _audioSystem.PlayGlobal(stream, null, AudioParams.Default.WithVolume(db).WithPlayOffset(offset)); // TODO: Positional audio. | ||
| var db = 20 * MathF.Log10(soundData.Volume / 100.0f); // convert from DM volume (0-100) to OpenAL volume (db) |
Collaborator
Author
There was a problem hiding this comment.
The / 100.0f has been moved from the only PlaySound() method call to in the method itself. Not sure if that's the right move or not but it simplifies things.
ike709
commented
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2194
SoundQuery()for a subset of implemented/implementable sound datum variablesrepeat=1sound looping.repeat=2is a TODO that likely requires some work on RT's side