Typemaker 1.1 Rebased Redux #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

ike709 wants to merge 17 commits into OpenDreamProject:master from ike709:typemakersplit

Collaborator

ike709 commented Jun 16, 2025 •

edited

Loading

Essentially just revives #2208 with some key differences:

No merge conflicts (yet)
Does not do as params at all. This PR is large enough as-is and I don't want to figure out the passing around procParameters mess
Tweaked the error message for typemaker
Fixed the morbillion formatting warnings
Fixed an NRE on compiling testgame
Fixed some other stuff that I forgot about between committing and writing this desc
Support astype() in typemaker
Handle ImplicitNullType for proc args

Note that passing the --skip-anything-typecheck compiler option is still strongly recommended for trying to actually use typemaker.

Also don't forget to elevate the typemaker pragmas to warnings/errors for this to actually do anything.

Future PR things:

alist() support
More unit tests
Revisit as params from the original PR

ike709 added 6 commits

June 16, 2025 05:36


          Initial commit


          fixes

5e515b8

fix

8696a00


          fix + astype() support

817443e


          tweak messages

97df0f1


          Emit ImplicitNullType for args

ee138ea

boring-cyborg bot added the Compiler label

github-actions bot added the size/XL label

ike709 requested a review from wixoaGit

June 16, 2025 12:27

github-advanced-security bot found potential problems

View reviewed changes

DMCompiler/Compiler/DM/DMParser.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Builders/DMProcBuilder.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Builders/DMProcBuilder.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Builders/DMProcBuilder.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Builders/DMProcBuilder.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Expressions/Builtins.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Expressions/Builtins.cs Fixed Show fixed Hide fixed

DMCompiler/DM/Expressions/Dereference.cs Fixed Show fixed Hide fixed

DMCompiler/DreamPath.cs

    
                  public DreamPath GetLastCommonAncestor(DMCompiler compiler, DreamPath other) {

                      var thisObject = compiler.DMObjectTree.GetOrCreateDMObject(this);

                      var otherObject = compiler.DMObjectTree.GetOrCreateDMObject(other);

Check warning

Code scanning / InspectCode

Expression is always false according to nullable reference types' annotations Warning

Expression is always false according to nullable reference types' annotations

DMCompiler/DreamPath.cs

    
                  public DreamPath GetLastCommonAncestor(DMCompiler compiler, DreamPath other) {

                      var thisObject = compiler.DMObjectTree.GetOrCreateDMObject(this);

                      var otherObject = compiler.DMObjectTree.GetOrCreateDMObject(other);

Check warning

Code scanning / InspectCode

Expression is always false according to nullable reference types' annotations Warning

Expression is always false according to nullable reference types' annotations

ike709 added 4 commits

June 16, 2025 07:38


          more formatting fixes

8112c6d


          fix var/icon/i vars not matching as icon

4b9deac


          fix sound handling

baaa908


          fix explicit anything on local vars

72f18c5

github-actions bot commented Jun 20, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions bot added the Merge Conflict label


          Merge branch 'master' into typemakersplit

5c7e0fc

github-actions bot removed the Merge Conflict label

wixoaGit mentioned this pull request

Typemaker 1.1 rebased - fixes and improvements #2208

Closed

github-actions bot added the Merge Conflict label

github-actions bot commented Jun 22, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.


          Merge branch 'master' into typemakersplit

a1252e1

github-actions bot removed the Merge Conflict label


          Missing comma

a02b780

github-actions bot added the Merge Conflict label

github-actions bot commented Jun 26, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.


          Merge branch 'master' into typemakersplit

be2e566

github-actions bot removed the Merge Conflict label

github-actions bot commented Jul 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions bot added the Merge Conflict label


          Merge branch 'master' into typemakersplit

084305d

github-actions bot removed the Merge Conflict label


          nuke this

e05cddf

Member

wixoaGit commented Aug 9, 2025

This uses quite a few hacky solutions (like DMProcBuilder.CheckBlockReturnRecursive()) that would likely be better done in other ways like with the creation of a control flow graph. I've tried adding one to this PR, but it's turning out to be a very in-depth change.

I don't think this is mergeable in its current state. It would be ideal if this could be split up into multiple PRs so the problematic changes can be worked on more effectively and the non-problematic ones can be merged in.

ike709 marked this pull request as draft

September 15, 2025 17:35


          Merge branch 'master' into typemakersplit

23d4876

github-actions bot added the Merge Conflict label

github-actions bot commented Dec 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Compiler Merge Conflict size/XL