Merge v0.2#116
Merged
Merged
Conversation
…penDevicePartnership#100) Create a struct to allow waiting for interrupts without needing to block the core controller object. Move interrupt related code into its own module.
…penDevicePartnership#102) The previous implementation put restrictions on `wait_any_masked` and could result in concurrency issues. Also some minor clean-up and improvements.
Co-authored-by: RobertZ2011 <33537514+RobertZ2011@users.noreply.github.com> Co-authored-by: Adam Sasine <asasine@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Felipe Balbi <felipe.balbi@microsoft.com> Co-authored-by: Felipe Balbi <febalbi@microsoft.com>
…ntity Data, executing Hard Reset (OpenDevicePartnership#104) Builds on OpenDevicePartnership/embedded-usb-pd#64 --------- Co-authored-by: Copilot <copilot@github.com>
Bumps `device-driver` from 1.0.3 to 1.0.9. - Updated `Cargo.toml` dependency declaration. - Refreshed `Cargo.lock` via `cargo build`. - Certified `device-driver` 1.0.9 as `safe-to-run` via cargo-vet. Co-authored-by: Felipe Balbi <febalbi@microsoft.com>
Co-authored-by: RobertZ2011 <33537514+RobertZ2011@users.noreply.github.com> Co-authored-by: Adam Sasine <asasine@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Felipe Balbi <felipe.balbi@microsoft.com> Co-authored-by: Felipe Balbi <febalbi@microsoft.com>
Closed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Embassy async interrupt handling to split “interrupt processing” (clearing/reading IRQ state from the device) from “interrupt reception” (waiting on signaled interrupt flags), and introduces per-port command-completion signaling plus configurable interrupt-clear timeouts.
Changes:
- Introduces
InterruptProcessorandInterruptReceiverin a newasynchronous::embassy::interruptmodule, moving interrupt logic and tests out ofembassy/mod.rs. - Updates the Embassy
Controllerto accept aConfig(incl. interrupt timeout config), addscommand_completesignals, and changesmake_parts()to return(Tps6699x, InterruptProcessor, InterruptReceiver). - Updates Embassy tasks and RT685S EVK examples to use the new interrupt processor/receiver split.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/asynchronous/embassy/task.rs | Updates interrupt task wiring to use InterruptProcessor. |
| src/asynchronous/embassy/mod.rs | Adds controller config + command completion signals; removes old interrupt/wait APIs and returns new parts. |
| src/asynchronous/embassy/interrupt.rs | New module containing interrupt processing/receiving logic and associated tests. |
| examples/rt685s-evk/src/bin/plug_status.rs | Migrates example to new controller constructor and interrupt receiver API. |
| examples/rt685s-evk/src/bin/fw_update.rs | Migrates example to new controller constructor and interrupt processor API. |
tullom
approved these changes
May 21, 2026
kurtjd
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.