Skip to content
This repository was archived by the owner on Oct 9, 2023. It is now read-only.

Conversation

@jeremyh
Copy link
Contributor

@jeremyh jeremyh commented Jul 12, 2023

There's no reason to use eodatasets1 now -- move remaining code to eodatasets3.

  • The CI was broken due to black/flake8 mismatches. I've fixed those and also upgraded the CI settings to match the eugl repo.
  • the ard_pbs script wasn't detected by black/etc, but it is now, so the diff is a little larger. Can disable this if needed. I've disabled pyupgrade too, as the unnecessary changes are larger.
  • I initially started porting the s2-nci-processing, but realised it's too outdated to still be used by anyone -- it hard-codes collection paths that have long since been removed. So I've removed it instead. Tell me if we'd prefer to keep it.

@jeremyh jeremyh changed the title Remove eodatasets1 dependency Fix build, remove eodatasets1 dependency Jul 12, 2023
@jeremyh jeremyh marked this pull request as ready for review July 14, 2023 02:35
@jeremyh jeremyh requested review from ohehir and uchchwhash and removed request for uchchwhash July 14, 2023 02:35
@uchchwhash uchchwhash self-requested a review July 21, 2023 01:38
Copy link
Contributor

@uchchwhash uchchwhash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants