Conversation
b6ed570 to
55a5615
Compare
This comment was marked as outdated.
This comment was marked as outdated.
55a5615 to
42a990f
Compare
d53ad72 to
d30391d
Compare
|
@pavel-kirienko Please have a look when you have time. Those two fixes for |
9234e4d to
e40f259
Compare
|
I think the missing As for the missing |
e40f259 to
9f0b95a
Compare
pavel-kirienko
left a comment
There was a problem hiding this comment.
This is fine but we need to avoid API breakage. Please tweak the arguments as suggested. You will also need to undo some of the changes to the test suite since they will no longer be necessary.
| error_handler: typing.Optional[ErrorHandler], | ||
| no_automatic_retransmission: bool, |
There was a problem hiding this comment.
| error_handler: typing.Optional[ErrorHandler], | |
| no_automatic_retransmission: bool, | |
| no_automatic_retransmission: bool, | |
| error_handler: ErrorHandler | None = None, |
A default is needed to avoid API breakage. Please update implementations.
Updated pydsdl does not like it. It was breaking many tests.
9f0b95a to
463b291
Compare
Add hooks for errors