Transform RT delete into SF form #474
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanib
reviewed
Jan 6, 2026
src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/RecoveryTokenController.php
Show resolved
Hide resolved
src/Surfnet/StepupSelfService/SelfServiceBundle/Controller/RecoveryTokenController.php
Show resolved
Hide resolved
MKodde
force-pushed
the
425-csrf-on-token-deletion-endpoint-missing
branch
from
d7bafcc to
5065948
Compare
Works, - needs translation token attention - warn about new translations - Show ID of safe-store RT? - test coverage?
MKodde
force-pushed
the
425-csrf-on-token-deletion-endpoint-missing
branch
from
5065948 to
9968991
Compare
MKodde
changed the title
MKodde
force-pushed
the
425-csrf-on-token-deletion-endpoint-missing
branch
from
3417a3f to
7043328
Compare
johanib
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a form to remove the recovery token.
On this form, the user is warned about the removal and is asked for confirmation.
The texts are translated according to the regular 2fa token removal form so the tone of voice should match. But PO might want to sharpen these translations.
A test for this feature
will bewas added to the Behat test suite in stepup devconfOpenConext/OpenConext-devconf#68