Feature/issue 583 email templates to disk#595
Open
kayjoosten wants to merge 10 commits into
Open
Conversation
Both fields are now read from disk/parameters.yaml. Any values pushed via the management API are silently ignored — no events fired, no DB writes. Validation accepts but does not inspect either field.
SraaService now takes the %sraa% parameter (list of nameId strings) instead of SraaRepository. All callers updated. SraaProjector and SraaRepository kept for historical event replay compatibility.
DiskEmailTemplateService reads .html.twig files from config/openconext/email_templates/<locale>/<name>.html.twig with fallback locale support. Default templates added for en_GB and nl_NL. EmailTemplatesWarmer validates all templates at cache warmup and fails loudly if any are missing or contain invalid Twig syntax.
Remove fixtures and assertions for sraa/email_template validation that no longer applies. Update mocks from SraaRepository to SraaService in DeprovisionServiceTest and RightToBeForgottenCommandHandlerTest.
Test that a push with only gateway is accepted, and that a push containing sraa and email_templates is silently accepted without error.
Templates were previously written from scratch with incorrect content and variables. Now use the reference templates from OpenConext/OpenConext-devconf as the default content.
localizeddate is not registered in the Twig environment (BackwardsCompatibleExtension is not wired as a service). format_date is the native twig/intl-extra equivalent and is available. Also allow format_date in the Twig sandbox policy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.