add use IDP LOA (authnContextClassReff) in Stepup Decision #1893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
fixes #1883 |
tvdijen
reviewed
Nov 29, 2025
tvdijen
reviewed
Nov 29, 2025
Contributor
Author
|
the commit history is not very nice any more but all tests are passing now |
tvdijen
reviewed
Nov 30, 2025
tvdijen
reviewed
Nov 30, 2025
| } | ||
|
|
||
| #[\PHPUnit\Framework\Attributes\Test] | ||
| #[\PHPUnit\Framework\Attributes\Group('Stepup')] |
Contributor
There was a problem hiding this comment.
I would personally add a few use-statements on the top of this file for these attributes and the exception below to keep the code better readable.
Contributor
Author
There was a problem hiding this comment.
I only added 1 for the exception. That is more in line with the other tests.
Contributor
There was a problem hiding this comment.
Fair enough! I'm a nitpicker anyway :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a feature flag to enable engineblock to use the AuthnContextClassReff in the response from the IDP in the stepupDecision.
This allows for IDPs to use their own MFA in combination with stepup.