Default feature block_user_on_violation to on #1282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For new installs this makes sense - the scope check is only done when you add scopes in Manage anyway, but if you add them, it's a safer default that they are actually enforced. The feature flag mostly exists to phase in scopes where you previously not had enabled them, so you want to start logging first.
thijskh
force-pushed
the
feature/enforce-scope-default-on
branch
from
22e45a3 to
04024ae
Compare
Member
Author
|
Feature flag will be removed in #1298 but this seems a useful change until then nonetheless |
MKodde
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new installs this makes sense - the scope check is only done when you add scopes in Manage anyway, but if you add them, it's a safer default that they are actually enforced.
The feature flag mostly exists to phase in scopes where you previously not had enabled them, so you want to start logging first.