Skip to content

Refactor : update after code review#379

Open
Tit-Co wants to merge 28 commits intoOpenClassrooms-Student-Center:masterfrom
Tit-Co:refactor/update-after-code-review
Open

Refactor : update after code review#379
Tit-Co wants to merge 28 commits intoOpenClassrooms-Student-Center:masterfrom
Tit-Co:refactor/update-after-code-review

Conversation

@Tit-Co
Copy link

@Tit-Co Tit-Co commented Mar 23, 2026

Summary

  • The app needs refactor to clean code and improve tests

Improvement

Refactor

  • competition out dated : message in ui instead of button and error message
  • Separate tests in couple of files and rename tests file : test_utils.py, test_views.py
  • Move utils fonctions from è server.pytoutils.py`
  • Keep and test error_tag in tests
  • Refactor some parts of code in 'validate' functions : passwords, places, competition
  • Update tests

Tit-Co added 28 commits March 9, 2026 18:08
…ase places with not enough points, update unit tests
…ld not be able to book more than 12 places per competition, update unit tests
…ate not reflected, update unit tests with mocks
…d not be able to book more than 12 places per competition, update tests
…aces in past competitions should not be possible, add two more unit tests for that bug fix
…ould not be able to book more than places available, update unit tests
…, add one more unit test for that improvement, update unit tests
…er, add structure screenshots, update requirements.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant