fix: rename evaluation_strategy to eval_strategy in finetune script#1062
Open
Mr-Neutr0n wants to merge 1 commit intoOpenBMB:mainfrom
Open
fix: rename evaluation_strategy to eval_strategy in finetune script#1062Mr-Neutr0n wants to merge 1 commit intoOpenBMB:mainfrom
Mr-Neutr0n wants to merge 1 commit intoOpenBMB:mainfrom
Conversation
The `evaluation_strategy` argument was renamed to `eval_strategy` in transformers. This fixes the deprecation warning. Fixes OpenBMB#1045
|
Thanks for your effort! We maintain a dedicated Cookbook for fine-tuning — could you open a PR against MiniCPM-V-CookBook? The relevant script is finetune/finetune_lora.sh. We'd be happy to review and merge it. |
Author
|
Thanks for the guidance @airlsyn! I'll open a PR against the MiniCPM-V-CookBook repository instead. Should I close this PR, or would you prefer to keep it open for reference? |
Feel free to close this one. Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename
evaluation_strategytoeval_strategyinfinetune/finetune_lora.shto fix the deprecation warning from transformers.Changes
finetune/finetune_lora.sh: Changed--evaluation_strategyto--eval_strategyContext
The
evaluation_strategyargument was renamed toeval_strategyin the transformers library. Using the old name causes a deprecation warning.Fixes #1045