Use TUS to do replication and make it non-blocking when uploading #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raymondjacobson
approved these changes
Jan 14, 2026
Contributor
raymondjacobson
left a comment
raymondjacobson
left a comment
There was a problem hiding this comment.
seems good, one high level comment.
not 100% sure what the benefit is of having tus do server-server replication, but i dont see it hurting either
| return fmt.Errorf("failed to create TUS request: %w", err) | ||
| } | ||
|
|
||
| createReq.Header.Set("Tus-Resumable", "1.0.0") |
Contributor
There was a problem hiding this comment.
what's this version from? maybe we can lift it from version.go?
| } | ||
| // Handle image uploads immediately with synchronous replication | ||
| if upload.Template == JobTemplateImgSquare || upload.Template == JobTemplateImgBackdrop { | ||
| upload.Mirrors, err = ss.replicateFileParallel(ctx, formFileCID, filePath, upload.PlacementHosts) |
Contributor
There was a problem hiding this comment.
why not handle all replication async?
Contributor
Author
There was a problem hiding this comment.
i agree. unclear why the AI did this
alecsavvy
reviewed
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.