Sync users instead of roles into LDAP groups #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bers to LDAP by script
lukas-staab
requested changes
Jul 29, 2025
| */ | ||
| public function up(): void | ||
| { | ||
| Schema::create('role_group_relation', function (Blueprint $table) { |
Member
There was a problem hiding this comment.
Wie soll hier der migrationspfad von bestehenden Daten sein? aka ließt die bisherigen Gruppen aus speichert die zusammensetzung in der DB und stups mal das neue sync script.
2 Möglichkeiten: entweder die migration macht das mit, oder es gibt ein cmd Command Befehl den man dann ausführen muss - dass müsste dann auch ins Changelog beim Release.
imho ist variante 2 etwas robuster, generiert aber auch code den man "nie wieder" braucht (also außer halt genau bei dem Versionssprung).
Weiterer kleiner Vorteil von V2 ist, dass das frische migrieren long term etwas schneller ist, wenn mans in ein seperates command auslagert
Meinungen?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for the possibility to connect other SSO applications like Keycloak to the LDAP an successfully sync the groups the users belong to.