Merged
Conversation
Member
Author
|
This PR has merge conflicts that need to be resolved. The CI workflow addition looks good and follows the pattern used in other OpenAdapt repositories.\n\nNext steps:\n1. Resolve merge conflicts with main branch\n2. Verify CI workflow runs successfully after resolving conflicts\n3. Consider addressing the Python 3.12 syntax issues mentioned in the PR description (f-string escaping)\n\nThis is recent work (Jan 17) and should be merged soon after conflicts are resolved. |
- Add test.yml workflow that runs on PRs and main branch pushes - Test on Python 3.10 and 3.11 across ubuntu-latest and macos-latest - Use uv for fast dependency management - Run pytest and ruff linter/formatter checks - Linting checks are non-blocking to allow iteration on code quality - Fix multiple ruff linting issues (unused imports, f-string placeholders, ambiguous variable names) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
d3ce722 to
5da7114
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions CI workflow (
test.yml) for automated testing on pull requests and main branch pushes.Changes
New workflow:
.github/workflows/test.ymluvfor fast dependency managementCode quality improvements: Fixed multiple ruff linting issues
Test Plan
Notes
continue-on-error: trueto allow iteration on code quality without blocking CICo-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com