fix(cli): write correct dict format for --task in run command#24
Merged
fix(cli): write correct dict format for --task in run command#24
Conversation
WAA's run.py expects test config as {domain: [task_ids...]} dict, but
--task wrote a bare JSON array [task_id] causing TypeError when run.py
indexes by domain string key.
Now looks up the task's domain from test_all.json inside the container
and writes the correct {domain: [task_id]} format.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
run --task <uuid>writing wrong JSON format into the WAA container.Before: Wrote
["task-uuid"](JSON array)After: Writes
{"chrome": ["task-uuid"]}(dict keyed by domain)Root cause
WAA's
/client/run.pyline 397 doestest_all_meta = {args.domain: test_all_meta[args.domain]}, which indexes the config dict by domain string. A bare array causesTypeError: list indices must be integers or slices, not str.Fix
Instead of hardcoding the JSON, run a small Python script inside the container that reads
test_all.json, finds which domain contains the task, and writes the correct{domain: [task_id]}format.Test plan
run --task <uuid>on a live VM🤖 Generated with Claude Code