fix: [BUG][JAVA] vendorExtension.x-class-extra-annotation doesn't generate lists of annotations correctly#23750
Open
johnyherangi wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
johnyherangi
changed the title
johnyherangi
changed the title
jpfinne
reviewed
May 10, 2026
| } | ||
|
|
||
| @Test | ||
| public void testAllOfClassWithMultipleAnnotations() throws IOException { |
jpfinne
reviewed
May 10, 2026
| } | ||
|
|
||
| @Test | ||
| public void testAllOfClassWithSingleAnnotation() { |
Contributor
There was a problem hiding this comment.
Use the supportedLibraries @DataProvider to test all libraries
| } | ||
|
|
||
| @Test | ||
| public void testAllOfClassWithMultipleAnnotations() { |
jpfinne
reviewed
May 10, 2026
| } | ||
| } | ||
|
|
||
| // make sure the x-class-extra-annotation is always a List and always at least empty |
Contributor
There was a problem hiding this comment.
Create a reusable method, also available for other annotations and other generators (kotlin)
Maybe some static method: fixExtraAnnotation(Map<String, Object> vendorExtensions , String annotationName)
Contributor
|
@johnyherangi Nice feature. How can the user know that a list is now allowed for that specific annotation? Why only x-class-extra-annotation? There a at least 3 variants of x-xxx-extra-annotation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23749
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes Java/Spring codegen so
x-class-extra-annotationsupports single strings and YAML lists and emits all annotations. Also defaults this extension to an empty list when missing, and applies toallOfmodels and oneOf interfaces.x-class-extra-annotationtoList<String>inAbstractJavaCodegenusing the existing single/multi-value pattern; default to empty list when absent.oneof_interfacetemplates to iterate and emit each annotation using{{{.}}}.allOfmodels (Cat,Dog), plus theallOf-with-annotations.yamlschema.Written for commit 00388d6. Summary will update on new commits.