Skip to content

[dart-dio] fix the issue of multi layer issues with dart-dio code generation#23717

Open
fstotz wants to merge 2 commits intoOpenAPITools:masterfrom
fstotz:feature/dart_dio_fix_one_of_multi_layers
Open

[dart-dio] fix the issue of multi layer issues with dart-dio code generation#23717
fstotz wants to merge 2 commits intoOpenAPITools:masterfrom
fstotz:feature/dart_dio_fix_one_of_multi_layers

Conversation

@fstotz
Copy link
Copy Markdown

@fstotz fstotz commented May 7, 2026

This fixes the issues with multi layer class using oneOf in dart-dio
fixes #15467

The PR includes test for dart-dio, which are using the example from the ticket

@jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fix multi-level oneOf discriminator handling in dart-dio so generated built_value serializers/discriminators work correctly across deep hierarchies. Addresses #15467.

  • Bug Fixes
    • Use schema-local discriminator mappings when present; for inherited discriminators keep only true allOf descendants (no sibling leaks).
    • Order mapped models by inheritance depth (subclasses before parents) to pick the most specific type first.
    • Add discriminator vendor extensions (x-discriminator-mapped-models-nonself, x-has-discriminator-self-mapping, x-discriminator-self-mapping-name) and update templates to handle self vs non-self mappings reliably.
    • Add tests with issue_15467.json covering mapping filtering and ordering, and regenerate affected dart-dio samples.

Written for commit d9a2139. Summary will update on new commits.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [dart-dio] Discriminator with multi-layered subclasses causes the subclasses to have error in discriminators

1 participant