[php-nextgen]: Fix array defaults#23290
Open
coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
Open
[php-nextgen]: Fix array defaults#23290coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Author
|
php members: @jebentier @dkarlovi @mandrean @jfastnacht @ybelenko @renepardon |
Contributor
There was a problem hiding this comment.
1 issue found across 9 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java">
<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java:254">
P1: Array defaults are emitted using raw Java `toString()` and injected unescaped into PHP templates, which can produce invalid PHP literals for string/object array defaults.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
|
||
| if (schema.getDefault() != null) { // array schema has default value | ||
| return "[" + schema.getDefault().toString() + "]"; | ||
| return schema.getDefault().toString(); |
Contributor
There was a problem hiding this comment.
P1: Array defaults are emitted using raw Java toString() and injected unescaped into PHP templates, which can produce invalid PHP literals for string/object array defaults.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java, line 254:
<comment>Array defaults are emitted using raw Java `toString()` and injected unescaped into PHP templates, which can produce invalid PHP literals for string/object array defaults.</comment>
<file context>
@@ -251,7 +251,7 @@ public String toDefaultValue(CodegenProperty codegenProperty, Schema schema) {
if (schema.getDefault() != null) { // array schema has default value
- return "[" + schema.getDefault().toString() + "]";
+ return schema.getDefault().toString();
} else if (schema.getItems().getDefault() != null) { // array item schema has default value
return "[" + toDefaultValue(schema.getItems()) + "]";
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The array default value is double-wrapped in arrays, because the default value is already an array.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Fixes array default handling in the
php-nextgengenerator to avoid double-wrapped defaults (e.g.,[["SUCCESS","FAILURE"]]->["SUCCESS","FAILURE"]). Regeneratedphp-nextgenandphp-nextgen-streamingPHP models and docs to reflect correct defaults.Written for commit a8f173b. Summary will update on new commits.