Skip to content

[php-nextgen]: Fix array defaults#23290

Open
coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
coffeemakr:features/fix-php-nextgen-array-defaults
Open

[php-nextgen]: Fix array defaults#23290
coffeemakr wants to merge 1 commit intoOpenAPITools:masterfrom
coffeemakr:features/fix-php-nextgen-array-defaults

Conversation

@coffeemakr
Copy link

@coffeemakr coffeemakr commented Mar 19, 2026

The array default value is double-wrapped in arrays, because the default value is already an array.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Fixes array default handling in the php-nextgen generator to avoid double-wrapped defaults (e.g., [["SUCCESS","FAILURE"]] -> ["SUCCESS","FAILURE"]). Regenerated php-nextgen and php-nextgen-streaming PHP models and docs to reflect correct defaults.

Written for commit a8f173b. Summary will update on new commits.

@coffeemakr
Copy link
Author

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 9 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java">

<violation number="1" location="modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java:254">
P1: Array defaults are emitted using raw Java `toString()` and injected unescaped into PHP templates, which can produce invalid PHP literals for string/object array defaults.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.


if (schema.getDefault() != null) { // array schema has default value
return "[" + schema.getDefault().toString() + "]";
return schema.getDefault().toString();
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Array defaults are emitted using raw Java toString() and injected unescaped into PHP templates, which can produce invalid PHP literals for string/object array defaults.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/PhpNextgenClientCodegen.java, line 254:

<comment>Array defaults are emitted using raw Java `toString()` and injected unescaped into PHP templates, which can produce invalid PHP literals for string/object array defaults.</comment>

<file context>
@@ -251,7 +251,7 @@ public String toDefaultValue(CodegenProperty codegenProperty, Schema schema) {
 
             if (schema.getDefault() != null) { // array schema has default value
-                return "[" + schema.getDefault().toString() + "]";
+                return schema.getDefault().toString();
             } else if (schema.getItems().getDefault() != null) { // array item schema has default value
                 return "[" + toDefaultValue(schema.getItems()) + "]";
</file context>
Fix with Cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant