fix(jaxrs): correct add/remove methods for JsonNullable<List<T>> fields

[TheNevim]

Summary

This PR fixes the incorrect implementation of add and remove helper methods generated for JsonNullable<List> fields in JAX-RS models.

The generated code incorrectly treated the field as an ArrayList, while the actual type is JsonNullable<List>. This resulted in compilation errors in the generated models.

The fix updates the generated methods to correctly handle the JsonNullable wrapper and operate on the underlying list.

Changes

• Corrected add and remove helper method implementations for JsonNullable<List> fields
• Ensured proper access to the underlying list within JsonNullable
• Fixed compilation errors in generated JAX-RS models

Result

Generated models now compile correctly and properly support add and remove operations for JsonNullable<List> fields.

Related Issue

Fixes #23251

PR checklist

• Read the contribution guidelines.
• Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
• Run the following to build the project and update samples:

  ./mvnw clean package || exit
  ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
  ./bin/utils/export_docs_generators.sh || exit
  

  (For Windows users, please run the script in WSL)
  Commit all changed files.
  This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
  These must match the expectations made by your contribution.
  You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
  IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
• File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
• If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
• If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
  @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

---

Summary by cubic

Fixes the generated add/remove/put helpers for JsonNullable<List<T>> and JsonNullable<Map<String, T>> in JAX-RS models so they compile and correctly modify the underlying collections.

• Bug Fixes
  • Updated the JavaJaxRS POJO template to initialize via JsonNullable.of(...), check .isPresent(), and mutate with .get() for optional-nullable arrays and maps.
  • Kept existing behavior for non-JsonNullable fields.
  • Models now compile and support collection helpers as expected. Fixes [BUG] [JAVA] [JAX-RS] Incorrect implementation of add/remove methods for JsonNullable<List<T>> fields in generated models #23251.

^{Written for commit e673d7c. Summary will update on new commits.}

[cubic-dev-ai]

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator/src/main/resources/JavaJaxRS/spec/pojo.mustache">

<violation number="1" location="modules/openapi-generator/src/main/resources/JavaJaxRS/spec/pojo.mustache:177">
P1: JsonNullable collection/map helpers incorrectly assume `isPresent()` implies non-null wrapped container, leading to NPE when wrapper is present with null (`JsonNullable.of(null)`).</violation>
</file>

---

Since this is your first cubic review, here's how it works:

• cubic automatically reviews your code and comments on bugs and improvements
• Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
• Add one-off context when rerunning by tagging @cubic-dev-ai with guidance or docs links (including llms.txt)
• Ask questions if you need clarification on any suggestion

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

P1: JsonNullable collection/map helpers incorrectly assume isPresent() implies non-null wrapped container, leading to NPE when wrapper is present with null (JsonNullable.of(null)).

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At modules/openapi-generator/src/main/resources/JavaJaxRS/spec/pojo.mustache, line 177:

<comment>JsonNullable collection/map helpers incorrectly assume `isPresent()` implies non-null wrapped container, leading to NPE when wrapper is present with null (`JsonNullable.of(null)`).</comment>

<file context>
@@ -173,36 +173,84 @@ public class {{classname}} {{#parent}}extends {{{.}}}{{/parent}} {{#vendorExtens
   {{#isArray}}
   public {{classname}} add{{nameInPascalCase}}Item({{{items.datatypeWithEnum}}} {{name}}Item) {
+    {{#vendorExtensions.x-is-jackson-optional-nullable}}
+    if (this.{{name}} == null || !this.{{name}}.isPresent()) {
+      this.{{name}} = JsonNullable.<{{{datatypeWithEnum}}}>of({{{defaultValue}}}{{^defaultValue}}new {{#uniqueItems}}LinkedHashSet{{/uniqueItems}}{{^uniqueItems}}ArrayList{{/uniqueItems}}<>(){{/defaultValue}});
+    }
</file context>