feature: add profile to skip Gradle tests when Maven tests are skipped. Use same java version for the gradle task as for the maven#23253
Open
Picazsoo wants to merge 3 commits intoOpenAPITools:masterfrom
Conversation
…d. Use same java version for the gradle task as for the maven
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator-gradle-plugin/pom.xml">
<violation number="1" location="modules/openapi-generator-gradle-plugin/pom.xml:136">
P2: Gradle-test skipping profile only watches `maven.test.skip`, so common `-DskipTests` builds still execute Gradle tests.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
There was a problem hiding this comment.
2 issues found across 1 file (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="modules/openapi-generator-gradle-plugin/pom.xml">
<violation number="1" location="modules/openapi-generator-gradle-plugin/pom.xml:167">
P2: Profile activation checks only for presence of `skipTests`, so `-DskipTests=false` still activates and skips Gradle tests.</violation>
<violation number="2" location="modules/openapi-generator-gradle-plugin/pom.xml:183">
P2: `-DskipTests` is mapped to Gradle `assemble`, which skips the full `check` lifecycle (not only tests), making the skip behavior broader than intended.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…serving quality checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes I just want to quickly rebuild the project and skip tests. However the tests in gradle maven wrapper still execute. This changes the behavior. Also the gradle inherits jdk from the parent maven task when executed as part of the maven build. This makes it possible to e.g. set a specific jdk version for maven in IDEA and have the gradle task also use it instead to falling back to the default OS JDK
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)Summary by cubic
Aligns the Gradle plugin build with Maven: Gradle now runs on Maven’s JVM and mirrors Maven test-skip flags while keeping quality checks.
Adds
skip-gradle-testsandskip-gradle-tests-skipTestsMaven profiles that append-x testto the Gradlebuildwhen-Dmaven.test.skip=trueor-DskipTestsis set; sets-Dorg.gradle.java.home=${java.home}so the Gradle daemon uses the same JDK.Written for commit 95cd659. Summary will update on new commits.