Skip to content

feature: add profile to skip Gradle tests when Maven tests are skipped. Use same java version for the gradle task as for the maven#23253

Open
Picazsoo wants to merge 3 commits intoOpenAPITools:masterfrom
Picazsoo:feature/skip-gradle-tests-together-with-maven-tests-and-tie-jvm-version
Open

feature: add profile to skip Gradle tests when Maven tests are skipped. Use same java version for the gradle task as for the maven#23253
Picazsoo wants to merge 3 commits intoOpenAPITools:masterfrom
Picazsoo:feature/skip-gradle-tests-together-with-maven-tests-and-tie-jvm-version

Conversation

@Picazsoo
Copy link
Contributor

@Picazsoo Picazsoo commented Mar 15, 2026

Sometimes I just want to quickly rebuild the project and skip tests. However the tests in gradle maven wrapper still execute. This changes the behavior. Also the gradle inherits jdk from the parent maven task when executed as part of the maven build. This makes it possible to e.g. set a specific jdk version for maven in IDEA and have the gradle task also use it instead to falling back to the default OS JDK

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. - Tagging: @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) @dennisameling (2026/02), @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08), @wing328

Summary by cubic

Aligns the Gradle plugin build with Maven: Gradle now runs on Maven’s JVM and mirrors Maven test-skip flags while keeping quality checks.

Adds skip-gradle-tests and skip-gradle-tests-skipTests Maven profiles that append -x test to the Gradle build when -Dmaven.test.skip=true or -DskipTests is set; sets -Dorg.gradle.java.home=${java.home} so the Gradle daemon uses the same JDK.

Written for commit 95cd659. Summary will update on new commits.

…d. Use same java version for the gradle task as for the maven
@Picazsoo Picazsoo marked this pull request as ready for review March 15, 2026 12:54
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator-gradle-plugin/pom.xml">

<violation number="1" location="modules/openapi-generator-gradle-plugin/pom.xml:136">
P2: Gradle-test skipping profile only watches `maven.test.skip`, so common `-DskipTests` builds still execute Gradle tests.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="modules/openapi-generator-gradle-plugin/pom.xml">

<violation number="1" location="modules/openapi-generator-gradle-plugin/pom.xml:167">
P2: Profile activation checks only for presence of `skipTests`, so `-DskipTests=false` still activates and skips Gradle tests.</violation>

<violation number="2" location="modules/openapi-generator-gradle-plugin/pom.xml:183">
P2: `-DskipTests` is mapped to Gradle `assemble`, which skips the full `check` lifecycle (not only tests), making the skip behavior broader than intended.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant