[backend/frontend] feat(netexec): add NetExec injector integration with 12 new finding types (#4989)#5092
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5092 +/- ##
============================================
+ Coverage 57.83% 58.13% +0.29%
- Complexity 4720 4818 +98
============================================
Files 1017 1029 +12
Lines 30158 30379 +221
Branches 2203 2250 +47
============================================
+ Hits 17442 17660 +218
- Misses 11680 11683 +3
Partials 1036 1036 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Please hold this one until we merge #4988 |
|
Seems merged now isn't @antoinemzs ? |
Ah yes, into another PR. Sorry. Let's track #4975 instead. |
|
#4975 is merged, so I’m picking this up again. The code looks good so far, but I’ll follow up with tests. |
Thanks a lot @savacano28 :) |
Please remember to reparent the findings processors to the FindingsCapableProcessor base class. cc @Seb-MIGUEL |
|
Additionally, I will be vigilant with the auto testing, specifically please cover from the |
1e3236e to
8b1533c
Compare
e71edce to
37d4637
Compare
673991d to
f7720dc
Compare
antoinemzs
left a comment
There was a problem hiding this comment.
Small nitpicks. I'm approving ahead of fixing so that you can go forward without requiring more involvement from me, but please do consider the comments!
Thanks for the tests
f7720dc to
d40191c
Compare





Summary
ContractOutputTypeentries and their correspondingOutputProcessorhandlers for NetExec findings (credentials, kerberoastable accounts, shares, vulnerabilities, etc.)catalog-integrators.json) and health check registry (ExternalServiceDependency)Closes #4989
Related to #OpenAEV-Platform/injectors#188 and OpenAEV-Platform/client-python#192
Test plan