Skip to content

[backend/frontend] feat(netexec): add NetExec injector integration with 12 new finding types (#4989)#5092

Merged
savacano28 merged 12 commits intomasterfrom
4989-netexec-clean
Mar 30, 2026
Merged

[backend/frontend] feat(netexec): add NetExec injector integration with 12 new finding types (#4989)#5092
savacano28 merged 12 commits intomasterfrom
4989-netexec-clean

Conversation

@Seb-MIGUEL
Copy link
Copy Markdown
Contributor

@Seb-MIGUEL Seb-MIGUEL commented Mar 4, 2026

Summary

  • Add 12 new ContractOutputType entries and their corresponding OutputProcessor handlers for NetExec findings (credentials, kerberoastable accounts, shares, vulnerabilities, etc.)
  • Add unit tests for all 12 OutputProcessor handlers
  • Register NetExec in the catalog (catalog-integrators.json) and health check registry (ExternalServiceDependency)
  • Add frontend support: new finding icons and contract output element cards

Closes #4989
Related to #OpenAEV-Platform/injectors#188 and OpenAEV-Platform/client-python#192

Test plan

  • CI passes (build + existing tests)
  • 12 new OutputProcessor unit tests pass
  • NetExec appears in the catalog/marketplace
  • New finding types render correctly in the frontend

@Seb-MIGUEL Seb-MIGUEL changed the title [#4989] Add NetExec injector integration with 12 new finding types [frontend][backend] feat(netexec): add NetExec injector integration with 12 new finding types (#4989) Mar 4, 2026
@Seb-MIGUEL Seb-MIGUEL changed the title [frontend][backend] feat(netexec): add NetExec injector integration with 12 new finding types (#4989) [backend/frontend] feat(netexec): add NetExec injector integration with 12 new finding types (#4989) Mar 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 95.08929% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.13%. Comparing base (5112ec5) to head (1d170df).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...v/output_processor/CredentialsOutputProcessor.java 26.66% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5092      +/-   ##
============================================
+ Coverage     57.83%   58.13%   +0.29%     
- Complexity     4720     4818      +98     
============================================
  Files          1017     1029      +12     
  Lines         30158    30379     +221     
  Branches       2203     2250      +47     
============================================
+ Hits          17442    17660     +218     
- Misses        11680    11683       +3     
  Partials       1036     1036              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@savacano28 savacano28 self-requested a review March 5, 2026 09:00
@antoinemzs
Copy link
Copy Markdown
Member

antoinemzs commented Mar 6, 2026

Please hold this one until we merge #4988

@antoinemzs antoinemzs added the do not merge Do not merge this PR until this tag will be removed label Mar 6, 2026
@Seb-MIGUEL
Copy link
Copy Markdown
Contributor Author

Seems merged now isn't @antoinemzs ?

@antoinemzs
Copy link
Copy Markdown
Member

Seems merged now isn't @antoinemzs ?

Ah yes, into another PR. Sorry. Let's track #4975 instead.

@savacano28 savacano28 removed do not merge Do not merge this PR until this tag will be removed labels Mar 18, 2026
@savacano28
Copy link
Copy Markdown
Contributor

#4975 is merged, so I’m picking this up again. The code looks good so far, but I’ll follow up with tests.

@Seb-MIGUEL
Copy link
Copy Markdown
Contributor Author

#4975 is merged, so I’m picking this up again. The code looks good so far, but I’ll follow up with tests.

Thanks a lot @savacano28 :)

@antoinemzs
Copy link
Copy Markdown
Member

#4975 is merged, so I’m picking this up again. The code looks good so far, but I’ll follow up with tests.

Please remember to reparent the findings processors to the FindingsCapableProcessor base class.

cc @Seb-MIGUEL

@antoinemzs
Copy link
Copy Markdown
Member

Additionally, I will be vigilant with the auto testing, specifically please cover from the process() method to ensure a real coverage 🙏

@savacano28 savacano28 force-pushed the 4989-netexec-clean branch 4 times, most recently from 1e3236e to 8b1533c Compare March 24, 2026 10:29
@savacano28 savacano28 requested a review from antoinemzs March 24, 2026 14:23
@savacano28
Copy link
Copy Markdown
Contributor

savacano28 commented Mar 24, 2026

Tests:
Update list of Contract types:
Payload/ContractOutputParsers: OK
image
Findings List types: OK
image

Execution Injects:

  • PasswordPolicy
image image

Nextec in catalog:
image

Copy link
Copy Markdown
Contributor

@savacano28 savacano28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with different injects and types (old and new types)

@savacano28 savacano28 force-pushed the 4989-netexec-clean branch 3 times, most recently from 673991d to f7720dc Compare March 30, 2026 07:22
Copy link
Copy Markdown
Member

@antoinemzs antoinemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicks. I'm approving ahead of fixing so that you can go forward without requiring more involvement from me, but please do consider the comments!

Thanks for the tests

Comment thread openaev-front/src/utils/injector_contract/InjectorContractUtils.ts
Comment thread openaev-front/src/admin/components/findings/ContractOutputElementType.ts Outdated
@savacano28 savacano28 merged commit 807099d into master Mar 30, 2026
13 checks passed
@savacano28 savacano28 deleted the 4989-netexec-clean branch March 30, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow full netexec integrations (front & News Findings type)

3 participants