Skip to content

Merge pull request #180 from Open-VCS/Dev#181

Closed
Jordonbc wants to merge 1 commit intoDevfrom
stable
Closed

Merge pull request #180 from Open-VCS/Dev#181
Jordonbc wants to merge 1 commit intoDevfrom
stable

Conversation

@Jordonbc
Copy link
Collaborator

/oc can you fix the before build script path in tauri config and ensure it correctly builds for both development and github workflows

@Jordonbc Jordonbc closed this Mar 19, 2026
@github-actions
Copy link

Pull Request Review

Summary

This PR fixes the beforeBuildCommand path in Backend/tauri.conf.json from node ../Backend/scripts/run-tauri-before-command.js build to node scripts/run-tauri-before-command.js build.

Issue Found: Incomplete Fix

The beforeDevCommand still has the wrong path. It currently reads:

"beforeDevCommand": "node ../Backend/scripts/run-tauri-before-command.js dev"

This is inconsistent with the fixed beforeBuildCommand. Both commands should use the same relative path pattern (scripts/), since Tauri executes both from the Backend/ directory (as confirmed by projectPath: Backend in all workflows).

Impact: The beforeDevCommand is likely broken and will fail when running cargo tauri dev.

Recommended Fix

"beforeDevCommand": "node scripts/run-tauri-before-command.js dev"

Minor Observations

  1. The script run-tauri-before-command.js correctly uses path.resolve(scriptDir, '..') to locate the backend directory, so it works correctly regardless of the calling path.
  2. The workflow publish-stable.yml correctly uses FRONTEND_SKIP_BUILD=1 since it pre-builds the frontend, bypassing the beforeBuildCommand entirely.
  3. The change itself is correct for the build command path.

Recommendation: Fix the beforeDevCommand path in the same commit before merging.

New%20session%20-%202026-03-19T03%3A25%3A58.657Z
opencode session  |  github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant