refactor server.py for using Blueprint#3033
Open
JanEisermann wants to merge 32 commits intoOpen-MSS:developfrom
Open
refactor server.py for using Blueprint#3033JanEisermann wants to merge 32 commits intoOpen-MSS:developfrom
JanEisermann wants to merge 32 commits intoOpen-MSS:developfrom
Conversation
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 13, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
reviewed
Mar 20, 2026
ReimarBauer
requested changes
Mar 20, 2026
Member
ReimarBauer
left a comment
There was a problem hiding this comment.
That's good progress. We can already see it's becoming much more readable. You need to rearrange a few things.
The blueprints should contain as few additional functions as possible.
Especially not ones that need to be imported from other blueprints.
see comments
efd14d0 to
570f809
Compare
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
mslib/mscolab/blueprints/auth/templates/auth/user/status_password.html
Outdated
Show resolved
Hide resolved
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
ReimarBauer
reviewed
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #2081
Does this PR introduce a breaking change?
included Blueprint, fixed test_load_no_file
If the changes in this PR are manually verified, list down the scenarios covered::
tests succeed, not manually verified
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes?
If yes, include the list of Documentation changes
Checklist:
<type>: <subject>