Skip to content

fix viewId selection for dynamic sections #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Enquier wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix viewId selection for dynamic sections #229

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/ve-app/pane-left/left-pane.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,17 +434,20 @@ class LeftPaneController implements angular.IComponentController {
});
}
} else if (this.$state.includes('**.present.**')) {
const viewId = branch.type !== 'view' ? branch.viewId : branch.data.id;
let viewId = '';

// If clicked on a PE send the element.selected event for Tool Pane
if (!(branch.type === 'view' || branch.type === 'section')) {
viewId = branch.viewId;
const data = {
elementId: branch.data.id,
projectId: branch.data._projectId,
refId: branch.data._refId,
commitId: 'latest',
};
this.eventSvc.$broadcast<veCoreEvents.elementSelectedData>('element.selected', data);
} else {
viewId = branch.data.id;
}

void this.$state.go(
Expand Down