Skip to content

Conversation

@HansVRP
Copy link
Contributor

@HansVRP HansVRP commented Jan 12, 2026

No description provided.

@HansVRP
Copy link
Contributor Author

HansVRP commented Jan 12, 2026

PR to make the no UDP found error more informative:

OpenEoUdfException: No valid UDF found.

Signature errors:
  - Function 'apply_vectorcube' failed validation: Missing required parameter: 'geometries'

Found functions (none valid): apply_vectorcube

Expected signatures:
  - apply_timeseries(series, context)
  - apply_datacube(cube, context)
  - apply_hypercube(cube, context)
  - apply_vectorcube(geometries, cube, context)
  - Or a single-parameter function for generic UDF

Copy link
Member

@soxofaan soxofaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm short on time, but some quick notes

if I understand correctly, this PR introduces quite some duplication between validation and execution of a UDF, which will be annoying to maintain in the long term.
The validation also doesn't seem to check type annotations, while the execution part does, so there is risk on inconsistencies here.

design-wise I would consider encapsulating everything in a new class, say UdfCodeParser, so that it is more clear that all these new functions belong together (most of which will be hidden internals), and I would try to unify the validation and execution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants