Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #250 by ensuring that after packs are reloaded via the RPC client, the extension triggers a Refresh to reload the active solution and run conversion/update steps so UI data (e.g., Components view) doesn’t remain stale.
Changes:
- Adds a
reloadPackscommand handler that callsLoadPacksand then issues the extension Refresh command. - Updates command registration to invoke
reloadPacks(instead ofloadPacks) for thecmsis-csolution.reloadPackscommand. - Extends unit tests to verify Refresh is triggered after
reloadPacksand that the Refresh execution is not awaited.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/json-rpc/csolution-rpc-client.ts | Implements reloadPacks() to trigger a Refresh after LoadPacks, and wires it into the reload-packs command. |
| src/json-rpc/csolution-rpc-helper.test.ts | Updates service construction for new dependency and adds tests for the new reloadPacks behavior. |
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (4)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|

Fixes
Changes
Screenshots
Checklist