Skip to content

RPC: request refresh after LoadPacks#261

Merged
edriouk merged 3 commits into
mainfrom
fix/250
May 21, 2026
Merged

RPC: request refresh after LoadPacks#261
edriouk merged 3 commits into
mainfrom
fix/250

Conversation

@edriouk
Copy link
Copy Markdown
Collaborator

@edriouk edriouk commented May 20, 2026

Fixes

Changes

  • issue Refresh command to reload solution and perform convert after reloading packs

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@edriouk edriouk requested review from brondani and Copilot May 20, 2026 17:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses issue #250 by ensuring that after packs are reloaded via the RPC client, the extension triggers a Refresh to reload the active solution and run conversion/update steps so UI data (e.g., Components view) doesn’t remain stale.

Changes:

  • Adds a reloadPacks command handler that calls LoadPacks and then issues the extension Refresh command.
  • Updates command registration to invoke reloadPacks (instead of loadPacks) for the cmsis-csolution.reloadPacks command.
  • Extends unit tests to verify Refresh is triggered after reloadPacks and that the Refresh execution is not awaited.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/json-rpc/csolution-rpc-client.ts Implements reloadPacks() to trigger a Refresh after LoadPacks, and wires it into the reload-packs command.
src/json-rpc/csolution-rpc-helper.test.ts Updates service construction for new dependency and adds tests for the new reloadPacks behavior.

Comment thread src/json-rpc/csolution-rpc-client.ts
@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 20, 2026

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.02%.

Modified Files with Diff Coverage (4)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/json-rpc/csolution-rpc-client.factory.ts100.0%
Coverage rating: A Coverage rating: A
src/solutions/cmsis-toolbox.ts100.0%
Coverage rating: B Coverage rating: B
src/json-rpc/csolution-rpc-client.ts94.4%66
Coverage rating: A Coverage rating: A
src/solutions/solution-converter.ts100.0%
Total97.0%
🤖 Increase coverage with AI coding...
In the `fix/250` branch, add test coverage for this new code:

- `src/json-rpc/csolution-rpc-client.ts` -- Line 66

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Comment thread src/json-rpc/csolution-rpc-client.ts Outdated
Comment thread src/json-rpc/csolution-rpc-client.ts
Comment thread src/solutions/solution-converter.ts
Comment thread src/solutions/solution-converter.ts
@edriouk edriouk marked this pull request as ready for review May 21, 2026 13:38
Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edriouk edriouk merged commit 3fbd2ed into main May 21, 2026
12 checks passed
@edriouk edriouk deleted the fix/250 branch May 21, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants