Skip to content

Config Wizard: make smart-open annotation-driven for any file type#260

Merged
mguzmanm merged 3 commits into
mainfrom
cw_preview_files
May 21, 2026
Merged

Config Wizard: make smart-open annotation-driven for any file type#260
mguzmanm merged 3 commits into
mainfrom
cw_preview_files

Conversation

@mguzmanm
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm commented May 20, 2026

Fixes

#248

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 20, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@mguzmanm mguzmanm requested a review from Copilot May 20, 2026 14:48
@mguzmanm mguzmanm changed the title Config Wizard: make smart-open annotation-driven for any file type Remove file filter Config Wizard: make smart-open annotation-driven for any file type May 20, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands Configuration Wizard “smart open” behavior to be annotation-driven for any file type, and broadens VS Code contributions so the Config Wizard preview/editor can be used beyond C/C++ and .dbgconf files (addressing #248).

Changes:

  • Removed the extension-based candidate filter so Config Wizard routing is based solely on annotation detection.
  • Updated unit tests to cover annotation-driven routing for arbitrary/custom file extensions.
  • Broadened package.json menu when clauses and the Config Wizard custom editor selector to apply to all files.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/views/solution-outline/commands/open-command.ts Removes extension gating; Config Wizard routing now depends only on annotation detection.
src/views/solution-outline/commands/open-command.test.ts Reworks/extends tests to validate annotation-driven routing for non-C/C++ file types.
package.json Broadens menu contributions and custom editor selector to support Config Wizard across file types.

Comment thread src/views/solution-outline/commands/open-command.ts
Comment thread package.json
@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 20, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@mguzmanm mguzmanm requested a review from edriouk May 21, 2026 12:15
Comment thread package.json
Copy link
Copy Markdown
Collaborator

@edriouk edriouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mguzmanm mguzmanm merged commit 9fce7e8 into main May 21, 2026
12 checks passed
@mguzmanm mguzmanm deleted the cw_preview_files branch May 21, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants