Add link to CMSIS Solution settings from Problems view#256
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
Adds a clickable "Configure Environment Variables" diagnostic code link in the Problems view that opens the workspace settings filtered to cmsis-csolution.environmentVariables, addressing the request in issue #251 to make environment-variable diagnostics actionable.
Changes:
- Introduces a new
EnvironmentVariablesSettingsCommandregisteringcmsis-csolution.openEnvironmentVariablesSettings, activated indesktop/extension.ts. - Extends
ProblemDiagnosticActionResolverto detect "missing/non-existent" environment variable diagnostic messages and emit a code link targeting the new command. - Adds unit tests covering the new resolver branch, the command registration/behavior, and the end-to-end diagnostic wiring in
SolutionProblems.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/manifest.ts | Adds OPEN_ENV_VAR_SETTINGS_COMMAND_ID constant. |
| src/solutions/env-var-settings-command.ts | New command class to open workspace settings filtered to the env-vars setting. |
| src/solutions/env-var-settings-command.test.ts | Tests for command registration and default/custom setting argument behavior. |
| src/solutions/problem-diagnostic-action-resolver.ts | Adds env-var message patterns and resolver branch producing the new code link. |
| src/solutions/problem-diagnostic-action-resolver.test.ts | Unit tests for the new resolver branch. |
| src/solutions/solution-problems.test.ts | Integration-style tests verifying diagnostics include the new command link. |
| src/desktop/extension.ts | Instantiates and activates the new command alongside other extension components. |
|
Coverage Impact ⬆️ Merging this pull request will increase total coverage on Modified Files with Diff Coverage (3)
🛟 Help
|



Fixes
#251
Changes
Screenshots
Checklist