Skip to content

Add link to CMSIS Solution settings from Problems view#256

Merged
mguzmanm merged 3 commits into
mainfrom
pw_link_to_settings
May 19, 2026
Merged

Add link to CMSIS Solution settings from Problems view#256
mguzmanm merged 3 commits into
mainfrom
pw_link_to_settings

Conversation

@mguzmanm
Copy link
Copy Markdown
Contributor

@mguzmanm mguzmanm commented May 19, 2026

Fixes

#251

Changes

Screenshots

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing has been performed (if necessary).
  • 🛡️ Security impacts have been considered (if relevant).
  • 📖 Documentation updates are complete (if required).
  • 🧠 Third-party dependencies and TPIP updated (if required).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a clickable "Configure Environment Variables" diagnostic code link in the Problems view that opens the workspace settings filtered to cmsis-csolution.environmentVariables, addressing the request in issue #251 to make environment-variable diagnostics actionable.

Changes:

  • Introduces a new EnvironmentVariablesSettingsCommand registering cmsis-csolution.openEnvironmentVariablesSettings, activated in desktop/extension.ts.
  • Extends ProblemDiagnosticActionResolver to detect "missing/non-existent" environment variable diagnostic messages and emit a code link targeting the new command.
  • Adds unit tests covering the new resolver branch, the command registration/behavior, and the end-to-end diagnostic wiring in SolutionProblems.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/manifest.ts Adds OPEN_ENV_VAR_SETTINGS_COMMAND_ID constant.
src/solutions/env-var-settings-command.ts New command class to open workspace settings filtered to the env-vars setting.
src/solutions/env-var-settings-command.test.ts Tests for command registration and default/custom setting argument behavior.
src/solutions/problem-diagnostic-action-resolver.ts Adds env-var message patterns and resolver branch producing the new code link.
src/solutions/problem-diagnostic-action-resolver.test.ts Unit tests for the new resolver branch.
src/solutions/solution-problems.test.ts Integration-style tests verifying diagnostics include the new command link.
src/desktop/extension.ts Instantiates and activates the new command alongside other extension components.

@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 19, 2026

Qlty


Coverage Impact

⬆️ Merging this pull request will increase total coverage on main by 0.02%.

Modified Files with Diff Coverage (3)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/manifest.ts100.0%
Coverage rating: A Coverage rating: A
src/solutions/problem-diagnostic-action-resolver.ts100.0%
New Coverage rating: A
src/solutions/env-var-settings-command.ts100.0%
Total100.0%
🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@mguzmanm mguzmanm requested review from brondani and edriouk and removed request for edriouk May 19, 2026 08:26
Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
I would suggest to add this link also when it concerns this "west" error:
Image

@mguzmanm
Copy link
Copy Markdown
Contributor Author

Add a link to settings when west executable is not found.
image

Copy link
Copy Markdown
Collaborator

@brondani brondani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mguzmanm mguzmanm merged commit 0792752 into main May 19, 2026
12 checks passed
@mguzmanm mguzmanm deleted the pw_link_to_settings branch May 19, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants