Skip to content

Override transitive dependency version to address security issue#249

Merged
soumeh01 merged 2 commits into
mainfrom
security-update
May 8, 2026
Merged

Override transitive dependency version to address security issue#249
soumeh01 merged 2 commits into
mainfrom
security-update

Conversation

@soumeh01
Copy link
Copy Markdown
Collaborator

@soumeh01 soumeh01 commented May 7, 2026

@soumeh01 soumeh01 requested a review from JonatanAntoni May 7, 2026 14:13
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
npm/handlebars 4.7.9 🟢 6.1
Details
CheckScoreReason
Code-Review🟢 8Found 13/16 approved changesets -- score normalized to 8
Maintained🟢 1028 commit(s) and 4 issue activity found in the last 90 days -- score normalized to 10
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
Packaging⚠️ -1packaging workflow not detected
Security-Policy🟢 10security policy file detected
Token-Permissions⚠️ 0detected GitHub workflow tokens with excessive permissions
Binary-Artifacts🟢 10no binaries found in the repo
Pinned-Dependencies⚠️ 2dependency not pinned by hash detected -- score normalized to 2
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Fuzzing⚠️ 0project is not fuzzed
License🟢 10license file detected
Signed-Releases⚠️ -1no releases found
Branch-Protection⚠️ -1internal error: error during branchesHandler.setup: internal error: some github tokens can't read classic branch protection rules: https://github.com/ossf/scorecard-action/blob/main/docs/authentication/fine-grained-auth-token.md
SAST⚠️ 0SAST tool is not run on all commits -- score normalized to 0

Scanned Files

  • package-lock.json

@qltysh
Copy link
Copy Markdown

qltysh Bot commented May 7, 2026

Qlty


Coverage Impact

This PR will not change total coverage.

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@soumeh01 soumeh01 requested a review from brondani May 7, 2026 14:26
Comment thread package.json Outdated
"immutable@<=4.3.8": "^4.3.8",
"@tootallnate/once@<=3.0.1": "^3.0.1"
"@tootallnate/once@<=3.0.1": "^3.0.1",
"handlebars": "4.7.9"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will hard-pin all transitive dependencies to that specific version. Is that intended? Or do we need to be slightly more specific about the conditions we want to force-update?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, It needed to be specific
Update handlebars dependency version constraint

@soumeh01 soumeh01 merged commit 21f04f0 into main May 8, 2026
18 of 19 checks passed
@soumeh01 soumeh01 deleted the security-update branch May 8, 2026 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants