Skip to content

Conversation

@live4thee
Copy link
Contributor

This patch will enable the 'max_dirty_ratio' parameter from Open-CAS/ocf#757

With patched casadm:

$ casadm -G -n cleaning-alru -i 1
+===============================+=======+
| Parameter name                | Value |
+===============================+=======+
| Wake up time [s]              |    10 |
| Stale buffer time [s]         |   120 |
| Flush max buffers             |   256 |
| Activity threshold [ms]       |  1000 |
| Maximum dirty ratio [percent] |    75 |
+===============================+=======+

$ casadm -X -n cleaning-alru -i 1 -d 80
$ casadm -G -n cleaning-alru -i 1
+===============================+=======+
| Parameter name                | Value |
+===============================+=======+
| Wake up time [s]              |    10 |
| Stale buffer time [s]         |   120 |
| Flush max buffers             |   256 |
| Activity threshold [ms]       |  1000 |
| Maximum dirty ratio [percent] |    80 |
+===============================+=======+

The odd is, if upgrading from existing installation - the first '-G -n cleaning-alru' will report an ioctl failure. It will be OK after issuing an -X -n cleaning-alru -i 1 -d something. I guess that's due to the missing 'max_dirty_ratio' in existing metadata. If any examples that handle such issue, please guide me.

Thanks in advance.

@live4thee live4thee force-pushed the casadm/use-alru-max-dirty-ratio branch from 47473cf to d335cc5 Compare October 9, 2022 15:08
@CAS-Linux-Jenkins
Copy link

Can one of the admins verify this patch?

@mmichal10 mmichal10 force-pushed the casadm/use-alru-max-dirty-ratio branch from d335cc5 to 0a6952c Compare July 22, 2025 13:59
Kamoppl
Kamoppl previously approved these changes Jul 22, 2025
jfckm
jfckm previously approved these changes Jul 23, 2025
@Deixx Deixx dismissed stale reviews from jfckm and Kamoppl via ffaaaaf October 7, 2025 12:56
@Deixx Deixx force-pushed the casadm/use-alru-max-dirty-ratio branch 3 times, most recently from 0ecbcdb to 724049e Compare October 7, 2025 13:02
@Deixx
Copy link
Contributor

Deixx commented Oct 7, 2025

The PR has been updated to work with Open-CAS/ocf#895.

@Deixx Deixx force-pushed the casadm/use-alru-max-dirty-ratio branch from 724049e to f6fbef8 Compare October 7, 2025 13:10
@Deixx Deixx changed the title casadm: use alru max dirty ratio casadm: use alru dirty ratio trigger Oct 7, 2025
@Deixx Deixx force-pushed the casadm/use-alru-max-dirty-ratio branch 4 times, most recently from 8aef0c3 to 66513f5 Compare October 13, 2025 13:07
@Deixx Deixx force-pushed the casadm/use-alru-max-dirty-ratio branch from 66513f5 to c9e21f3 Compare October 14, 2025 12:14
robertbaldyga
robertbaldyga previously approved these changes Oct 14, 2025
Kamoppl
Kamoppl previously approved these changes Oct 14, 2025
Signed-off-by: Qun Li <qun.li@zstack.io>
Signed-off-by: Michal Mielewczyk <michal.mielewczyk@huawei.com>
@Deixx Deixx dismissed stale reviews from Kamoppl and robertbaldyga via 7e38ebc October 14, 2025 14:28
@Deixx Deixx force-pushed the casadm/use-alru-max-dirty-ratio branch from c9e21f3 to 7e38ebc Compare October 14, 2025 14:28
Deixx added 4 commits October 15, 2025 11:26
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
Signed-off-by: Daniel Madej <daniel.madej@huawei.com>
@Deixx Deixx force-pushed the casadm/use-alru-max-dirty-ratio branch from 7e38ebc to 6cf9dc9 Compare October 15, 2025 09:27
@robertbaldyga robertbaldyga merged commit 417ab1a into Open-CAS:master Oct 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants