Skip to content

Conversation

@jaredkhan
Copy link
Collaborator

@jaredkhan jaredkhan commented Jul 13, 2025

Fixes a bug whereby skipping the animation would sometimes drop you in the wrong place.

e.g. on my machine, on the main tree...

onezoom.controller.leap_to(426632)
// then...
onezoom.controller.fly_on_tree_to(null, -237600)
// then in the first seconds of the flight...
onezoom.controller.leap_to(-237600)

lands me in a blank page.

And in fact it still does in this PR, but now the skip animation doesn't call those functions like that because it waits for the previous flight to be cancelled.

We can likely make those functions work directly, by having each one wait for the flight to be cancelled, hence the draft, this is just where I got to this weekend.

@jaredkhan jaredkhan marked this pull request as draft July 13, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant