await cancel_flight in skip_flight #971
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug whereby skipping the animation would sometimes drop you in the wrong place.
e.g. on my machine, on the main tree...
lands me in a blank page.
And in fact it still does in this PR, but now the skip animation doesn't call those functions like that because it waits for the previous flight to be cancelled.
We can likely make those functions work directly, by having each one wait for the flight to be cancelled, hence the draft, this is just where I got to this weekend.