fix: exclude stale aegis/ directory from vitest runs#4398
Open
OneStepAt4time wants to merge 2 commits into
Open
fix: exclude stale aegis/ directory from vitest runs#4398OneStepAt4time wants to merge 2 commits into
OneStepAt4time wants to merge 2 commits into
Conversation
added 2 commits
May 28, 2026 09:47
The aegis/ directory contains a stale copy of source and tests that is not git-tracked but present on disk. Root vitest.config.ts excluded dashboard/** but not aegis/dashboard/**, aegis/src/**, or aegis/e2e/**, causing: - 28 dead-session test failures from stale monitor class - 4 content-length-static test failures from stale dashboard build - 1 e2e-dogfood test failure (missing dist/server.js in stale copy) Also installed missing 'open' dependency that caused TypeScript errors in cli-init, zero-config-init, init.ts, and login.ts. Test results: 406 files passed, 5,831 tests passed, 0 failures
Local check-bundle-size.sh had THRESHOLD_KB=2244 while CI uses 2508. This caused false failures in 'npm run gate' that wouldn't fail in CI. Synced to match the CI value from .github/workflows/ci.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
aegis/directory on disk contains a stale copy of source code and tests that is not git-tracked but is picked up by vitest. The rootvitest.config.tsexcludeddashboard/**but not the mirrored paths underaegis/.This caused 33 test failures across every local run:
aegis/src/__tests__/dead-session.test.ts(stale monitor class)aegis/src/__tests__/content-length-static.test.ts(stale dashboard build)aegis/e2e/e2e-dogfood.test.ts(missingdist/server.js)Also: the
openpackage was declared inpackage.jsondependencies but not installed, causing 5 TypeScript errors intsc --noEmit.Fix
aegis/dashboard/**,aegis/src/**,aegis/e2e/**to vitest exclude listopendependency (resolves TS2307 errors)Verification
tsc --noEmitclean (was 5 errors)aegis/copy — real source atsrc/passes all testsFiles Changed
vitest.config.ts— 3 exclude patterns addedpackage-lock.json—opendependency resolved