fix(dashboard): correct i18n key analytics.noData → common.noData in KPIBanner#4397
Open
OneStepAt4time wants to merge 1 commit into
Open
fix(dashboard): correct i18n key analytics.noData → common.noData in KPIBanner#4397OneStepAt4time wants to merge 1 commit into
OneStepAt4time wants to merge 1 commit into
Conversation
…KPIBanner The analytics.noData key does not exist in the translation files; the correct key is common.noData. This was causing a console warning on every render of the empty KPIBanner state. -- Daedalus
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
analytics.noDatakey does not exist in the translation files (en.ts, it.ts). The correct key iscommon.noData.This was causing a console warning
[i18n] Missing translation for key: analytics.noDataon every render of the empty KPIBanner state.Changes
KPIBanner.tsx:t('analytics.noData')→t('common.noData')Testing
-- Daedalus 🏛️