A11y Bug 8780675: Voice Access is showing numbers for the non interactive controls.#638
Merged
KethanaReddy7 merged 1 commit intouser/kpeddireddy/LocationButtonTabfrom Mar 11, 2026
Conversation
…erlay The Location text label was being treated as an interactive element by Voice Access, causing it to display a number for the non-interactive control. This fix adds aria-hidden="true" to the optionLabel div and changes the label element to a span, since screen reader accessibility is already provided by the addSrOnlyLocationDiv function. Fixes #634 Co-authored-by: KethanaReddy7 <KethanaReddy7@users.noreply.github.com>
Contributor
|
@KethanaReddy7 Please update the description with the summary. |
KethanaReddy7
merged commit dd82ed0
into
user/kpeddireddy/LocationButtonTab
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor accessibility and markup adjustment to the
SectionPickerClasscomponent. The change simplifies the label structure and ensures that the option label is correctly hidden from screen readers by moving thearia-hidden="true"attribute to the containerdivand removing the unnecessarylabelelement.src/scripts/clipperUI/components/sectionPicker.tsx, the option label markup is simplified by removing thelabelelement, movingaria-hidden="true"to the containerdiv, and keeping only the styledspanfor the visible text.Fixes A11y Bug 8780675: Voice Access is showing numbers for the non interactive controls. #634Summary
aria-hidden="true"to hide the Location label from Voice Access<label>to<span>since screen reader accessibility is provided byaddSrOnlyLocationDivTest Plan
Demo after fix
https://github.com/user-attachments/assets/1cb5adf3-cf8c-4e9e-bb20-ee7d0e340cad
Generated with Claude Code