[868gfp7y1] RoR Upgrade (Initial Step)

[ale1HQagui]

Description

Please describe your pull request and any relevant information.

Risk Level

• Low
• Med
• High

Rollback Plan

Please describe and add steps for rollback if needed.

Screenshots

Screenshots or videos of the feature/fix if needed.

Checklist

• I linked the change to an approved ticket
• I have added/updated appropriate tests and evidence
• I considered security/privacy impact
• I updated docs/runbook if needed
• I added a changelog/version entry for this PR

[grvp88]

Code Review

✅ Clean upgrade — excellent spec modernization

ActiveRecord::Base.send :include → ActiveRecord::Base.include

# Before (deprecated)
::ActiveRecord::Base.send :include, ::HasSafeDates::CoreExt
::ActiveRecord::Base.send :prepend, ::HasSafeDates::DateTimeExt

# After (idiomatic Ruby 3.x)
::ActiveRecord::Base.include ::HasSafeDates::CoreExt
::ActiveRecord::Base.prepend ::HasSafeDates::DateTimeExt

send to call include/prepend was a workaround for older Ruby visibility rules. In Ruby 3.x these are public methods — calling them directly is correct and avoids a warning.

required_ruby_version bumped to >= 3.4 — correct.

gemspec modernized — removed the version-conditional if Gem::Version block (a relic from pre-Bundler era). Replaced with clean direct dep declarations. Good cleanup.

Spec suite fully modernized

• All should matchers replaced with expect(...).to syntax
• describe → RSpec.describe
• {...} → do...end blocks for multi-line expects
• YAML::load → YAML.load_file (the :: form and manual IO.read was unnecessary)
• Single config.before(:each) / config.after(:each) collapsed to one-liners
  This is a meaningful improvement — the spec file was using RSpec 2 patterns in an RSpec 3 suite.

activerecord dev dep updated to ~> 7.2 — correct, tests now run against the target Rails version.

No CI — uses CircleCI (not Tekton), and the CI config has only an indentation fix in the cache keys section. No functional CI change.