Skip to content

Conversation

@Neeraj-Kondaveeti
Copy link
Contributor

@Neeraj-Kondaveeti Neeraj-Kondaveeti commented Jan 16, 2026

Description

This PR fixes a regression on the Job Analytics Competitive Roles page where the graph displayed “No data available” after the previous merge, despite valid backend data being present. The issue was caused by frontend handling of backend response variations, which led to valid data being normalized to zero and filtered out before rendering. This change restores the expected behavior by defensively normalizing the response data prior to chart rendering without altering existing filters, aggregation logic, or visual presentation.

image image image image

Related PRS (if any):

This frontend PR is related to the Development Backend branch.
This PR is hot fix for the frontend PR : #4010

Main changes explained:

  • Updated the Job Analytics graph component to normalize incoming analytics data before rendering.
  • Ensured application counts are derived safely from backend responses that may vary in shape across environments.
  • Prevented valid datasets from being incorrectly treated as empty and triggering the “No data available” state.
  • Preserved existing chart logic, filtering behavior, and visual presentation.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Navigate to : http://localhost:5173/job-analytics-competitive-roles
  6. Verify the graph renders correctly with default filters (Dates = All, Role = All, Granularity = Totals).
  7. Change role, date range, and granularity filters and confirm the chart updates as expected.

Screenshots or videos of changes:

image image

Note:

  • This PR is a minimal, frontend-only hotfix addressing a post-merge regression.
  • No backend endpoints, query logic, or aggregation behavior were modified.
  • The change is defensive and ensures compatibility with existing backend data across environments.
  • This PR is safe for immediate merge to restore expected functionality.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 171fda1
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/696aaf7f8f1e6800089e6b53
😎 Deploy Preview https://deploy-preview-4722--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

@Neeraj-Kondaveeti Neeraj-Kondaveeti added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Jan 16, 2026
@Neeraj-Kondaveeti Neeraj-Kondaveeti changed the title Neeraj Hotfix: Eestore Job Analytics Graph Data Rendering Neeraj Hotfix Restore Job Analytics Graph Data Rendering Jan 16, 2026
Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Neeraj,

Well done with this implementation.

PR 4722 Screenshot PR 4722 Screenshot 2

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Neeraj,

I have reviewed your PR locally and it does work as expected. I would like to point out that in dark mode the calendar is in light mode which reviewers might point out during merge.
Screenshot 2026-01-19 at 3 56 04 PM
Screenshot 2026-01-19 at 3 56 10 PM
Screenshot 2026-01-19 at 3 56 35 PM
Screenshot 2026-01-19 at 3 56 49 PM
Screenshot 2026-01-19 at 3 57 13 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants