Skip to content

Conversation

@KH07
Copy link
Contributor

@KH07 KH07 commented Dec 2, 2025

Description

Make the page fully compatible with dark mode, restore the page header, and update tooltip styling so tooltip colors match the corresponding legend colors.

Related PRS (if any):

This frontend PR is related to the #3081 front end PR.

Main changes explained:

  • Refactor AttendanceNoShowCharts.jsx for readability and ease of maintenance
  • Create AttendanceNoShowCharts.module.css to add dark mode styling support

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. Clear site data/cache
  4. log as any user
  5. go to http://localhost:3000/logattendance
  6. verify page header and dark mode renders correctly

Screenshots or videos of changes:

Log Attendance Page Dark Mode

@netlify
Copy link

netlify bot commented Dec 2, 2025

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 1c108cf
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/696c8695c4e19e0008f8d5ad
😎 Deploy Preview https://deploy-preview-4484--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

rohanrastogi311
rohanrastogi311 previously approved these changes Jan 7, 2026
Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI Kristin,

Well done with the implementation. Dark mode is functional. I believe this is out of scope but wanted to make you aware that boxes hovering the pie charts aren't visible in dark mode (check image below).

PR 4484 Screenshot PR 4484 Screenshot 2

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Kristin,

I have reviewed your PR locally and though the page is adapted to dark mode, and the header is visible as well. the only issue is the tooltip, it isn't visible in darkmode.
Screenshot 2026-01-07 at 11 03 56 PM
Screenshot 2026-01-07 at 11 03 15 PM
Screenshot 2026-01-07 at 11 03 46 PM

@KH07
Copy link
Contributor Author

KH07 commented Jan 13, 2026

HI Kristin,

Well done with the implementation. Dark mode is functional. I believe this is out of scope but wanted to make you aware that boxes hovering the pie charts aren't visible in dark mode (check image below).

PR 4484 Screenshot PR 4484 Screenshot 2

I have added dark mode styling for the charts' tooltip.
PR4484

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants