Siva/activity agenda dynamic routing #4434
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed route from /communityportal/ActivityAgenda to /communityportal/activity/:activityid - Enables dynamic routing based on activity ID - Fixes 'Page Not Found' issue when accessing activity details
…rameter" This reverts commit 3231509.
- Changed route from /communityportal/ActivityAgenda to /communityportal/activity/:activityid - Enables dynamic routing based on activity ID - Fixes 'Page Not Found' issue when accessing activity details - Route now accepts activityid as URL parameter
pavanputti
added
DO NOT MERGE
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Added useParams import from react-router-dom - Extract activityid parameter from URL route - Added validation and error handling for missing activityId - Component now receives activityId from URL parameter - Prepared component for dynamic data fetching in next commit
- Added EVENT_BY_ID endpoint to URL.js for fetching single event - Implemented useState hooks for eventData, loading, and error states - Added useEffect to fetch event data when component mounts or activityid changes - Implemented fallback logic: tries EVENT_BY_ID endpoint first, falls back to fetching all events and filtering by ID - Added data transformation to map event model fields to component structure - Implemented loading, error, and no-data states with user-friendly messages - Added proper error handling and validation for API responses
- Enhanced data transformation with better date/time formatting helpers - Added event metadata display (date, type, location, status, attendance) - Improved schedule display with better formatting and resource location - Added image error handling with fallback to default image - Enhanced UI structure with organized sections for metadata, description, and schedule - Improved styling with conditional dark mode support for metadata sections - Better handling of missing or incomplete event data - Added formatted date display with full date string - Enhanced schedule items with background styling and better layout
- Enhanced error handling with specific messages for different error types (404, network, server, permission errors) - Added validation for activity ID (empty string check) - Improved date/time formatting with NaN validation to prevent invalid date displays - Enhanced schedule building with null/undefined resource filtering - Added type checking for numeric values (maxAttendees, currentAttendees) - Improved fallback API call error handling with network error detection - Better event data validation (object type check) - Enhanced error messages for better user experience - Fixed date display logic to handle null dates properly - Added array validation for schedule and resources data
…er functions to reduce fetchEventData complexity from 31 to ≤15 - Extract render functions to reduce ActivityAgenda complexity from 17 to ≤15
…urcesUsage import and ActivityAgenda route from both branches
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include the exact bug/functionality description and a summary of the changes/ related issues. Please also include any other relevant motivation and context:
Fixes # (bug list priority high/medium/low x.y.z)
Or Implements # (WBS)
Related PRS (if any):
This frontend PR is related to the #XXX backend PR.
To test this backend PR you need to checkout the #XXX frontend PR.
…
Main changes explained:
…
How to test:
npm installand...to run this PR locallyScreenshots or videos of changes:
Note:
Include the information the reviewers need to know.