-
-
Notifications
You must be signed in to change notification settings - Fork 72
Taariq: Fix filterColor persistence issue on change and refresh for Individual as well as bulk Selected filterColors Frontend. #3916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
…select all functionality
✅ Deploy Preview for highestgoodnetwork-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sourabhbagde
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking to Test frontend changes due to backend error
Pulled PR OneCommunityGlobal/HGNRest#1667 for backend
Error: ReferenceError: dashboardMetrics is not defined. at runtime.
Root Cause: dashboardMetrics is referenced in src/startup/routes.js (passed into bmDashboardPrototypeRouter) even though the both src/models/bmdashboard/dashboardMetrics.js and src/routes/bmdashboard/bmDashboardPrototypeRouter.js were removed in this PR and are not defined.
Attaching screenshots - please refer and let me know if I am missing anything here.
akshith312
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@akshith312 the addition you mentioned should appear at the top right during bulk changes. I included it as a small enhancement, although it wasn’t originally part of the requirements. Thanks for reviewing it. |
RitzzzZ2021
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ShradhaMBhadrannavar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Hi Taariq, |
Hi @ManeeshBuddha21, Thanks for thoroughly testing it. Can you please approve the PR? |
Hi @Vinay944924, Thanks for thoroughly testing it. Can you please approve the PR? |
Hi @tomkkl, Thanks for thoroughly testing it. Can you please approve the PR? |
Sriamshreddy000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Taariq,
I tested this PR along with related backend PR#1667, logged in as an admin user. In reports -> Weekly summaries report, both of the individual and bulk color filters works as expected.
Verified from the browser console that the filterColor values are updated correctly in API responses, and the UI reflects the changes consistently. Toast notifications also appear on bulk selection, and everything works smoothly in light mode.
Anusha-Gali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rged into the development
91c75e8
|
|
Thank you all, merging! |
Vikas-8055
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this PR locally with backend PR #1667. Logged in as admin and navigated to Reports → Weekly Summaries Reports.
Verified: Individual color selection (single/multiple), bulk "Select All" functionality, toast notifications on bulk selection, and filter persistence until refresh. All features work as expected
Shravan-neelamsetty
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TaariqMansurie, I have tested this PR locally by checking out the taariq_fixing_angads_filter_branch_frontend branch along with the related backend PR #1667 and navigating to Reports → Weekly Summaries Reports. The filter color functionality works as expected - I can see the individual color dots (purple, green, navy) displayed next to each user in the list, and clicking them successfully updates the filter colors for individual users. I selected multiple team codes to verify the "Select All (Visible Users)" bulk filter feature, which correctly applies the selected color to all visible users and displays the toast notification as intended.

c367f5b
|















































Description
This PR introduces Filter by Special Colors (purple, green, navy) functionality for users in the selected team codes. Users can now be filtered individually by color (single or combination of purple, green, navy), and a new Select All (Visible Users) functionality has been added for bulk assigning a single filter color to all users at once.
Unlike the individual filter where multiple colors can be selected simultaneously, the bulk filter allows assigning only one color at a time for all visible users. This simplifies the workflow for admins by eliminating the need to assign colors individually.
A toast notification has also been added when a bulk filter color is applied.
Related PRS (if any):
This frontend PR is related to the backend PR 1667.
To test this frontend PR you need to checkout the backend PR too.
…
Main changes explained:
…
How to test:
npm installandnpm run start:localto run this PR locally.Screenshots or videos of changes:
filterColor.mp4
Note:
Please watch the video at 1.5x or 2.0x. Also the video was shot before, Toast message and also improving the UI was done later. So there will be slight differences while running it on your local system.