Improve _build_query time #16
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks @raman325. Did you test this? |
Contributor
Author
|
yes but I wasn't clear, was the intention to do a falsey check? I switched to using an explicit none check and wasn't sure if that would break anything |
Owner
|
I'm not sure, since this part was written by @cgtobi and I'm not sure if he's still active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process of updating the dictionary over and over with a new dictionary will be slower than using dict comprehension. Not sure how much of a speed up you'll gain but it's a small change that at worst barely makes a difference but at best makes a slight difference.
Also is the intent to make sure val is not
None? I assumed it is because this will filter out when val=0 or False as well, but if that's not correct I can update this