Skip to content

fix: resolve Invalid id in Terminal add in still installed error #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
archiesaxenaa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve Invalid id in Terminal add in still installed error #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/office-addin-dev-settings/src/publish.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,15 @@ export async function uninstallWithTeams(id: string): Promise<boolean> {
return new Promise((resolve, reject) => {
const guidRegex = /[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}/;
const manifestIdRegex = new RegExp(`^${guidRegex.source}$`);
const titleIdRegex = new RegExp(`^U_${guidRegex.source}$`);
const titleIdRegexU = new RegExp(`^U_${guidRegex.source}$`);
const titleIdRegexT = new RegExp(`^T_${guidRegex.source}$`);
let mode: string = "";

if (titleIdRegex.test(id)) {
if (titleIdRegexT.test(id)) {
// T_ IDs must be converted to manifest-id format (strip the T_ prefix)
const manifestId = id.substring(2);
mode = `--mode manifest-id --manifest-id ${manifestId}`;
} else if (titleIdRegexU.test(id)) {
mode = `--mode title-id --title-id ${id}`;
} else if (manifestIdRegex.test(id)) {
mode = `--mode manifest-id --manifest-id ${id}`;
Expand Down