Skip to content

Conversation

@Jason-W123
Copy link
Collaborator

@Jason-W123 Jason-W123 commented Dec 25, 2025

Disable chunked-store in datool dumpkeyset so it no longer requires a signer and can compute keyset hashes directly from configured backends.
If we don't disable it, this command will throw error panic: chunked store requires a valid signer for replay protection; cannot use nil signer

@Jason-W123 Jason-W123 changed the title default EnableChunkedStore to false for datool dumpKeyset Fix: default EnableChunkedStore to false for datool dumpKeyset Dec 25, 2025
@github-actions
Copy link

github-actions bot commented Dec 25, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
2171 4 2167 0
View the top 3 failed tests by shortest run time
TestOutOfGasInStorageCacheFlush
Stack Traces | 10.160s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestOutOfGasInStorageCacheFlush
ERROR[12-30|00:08:46.555] Dangling trie nodes after full cleanup
    program_test.go:2813: goroutine 689637 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c31d0, 0xc01995a8c0}, {0x40806c0, 0xc0bd23fc00}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc01995a8c0, {0x40806c0, 0xc0bd23fc00}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc01995a8c0)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2813 +0xfe6
        testing.tRunner(0xc01995a8c0, 0x3d08ef0)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2813: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
INFO [12-30|00:08:56.653] HTTP server stopped                      endpoint=127.0.0.1:36219
TRACE[12-30|00:08:56.653] P2P networking is spinning down
--- FAIL: TestOutOfGasInStorageCacheFlush (10.16s)
TestVersion40
Stack Traces | 11.300s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
INFO [12-30|00:07:37.345] HTTP server stopped                      endpoint=127.0.0.1:37621
TRACE[12-30|00:07:37.348] P2P networking is spinning down
    precompile_inclusion_test.go:90: goroutine 455315 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c31d0, 0xc0aa24ee00}, {0x4080b40, 0xc08eab2f60}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc0aa24ee00, {0x4080b40, 0xc08eab2f60}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc0aa24ee00, 0x28, {0xc09095bdf8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:90 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc0aa24ee00?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc0aa24ee00, 0x3d093d0)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:90: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (11.30s)
TestBatchPosterActuallyPostsBlobsToL1
Stack Traces | 26.730s run time
=== RUN   TestBatchPosterActuallyPostsBlobsToL1
=== PAUSE TestBatchPosterActuallyPostsBlobsToL1
=== CONT  TestBatchPosterActuallyPostsBlobsToL1
    batch_poster_test.go:884: goroutine 51 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40c31d0, 0xc00050ae00}, {0x4080660, 0x5e97060}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc00050ae00, {0x4080660, 0x5e97060}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:1790 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestBatchPosterActuallyPostsBlobsToL1(0xc00050ae00)
        	/home/runner/work/nitro/nitro/system_tests/batch_poster_test.go:884 +0x388
        testing.tRunner(0xc00050ae00, 0x3d08300)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    batch_poster_test.go:884: �[31;1m [] context deadline exceeded �[0;0m
--- FAIL: TestBatchPosterActuallyPostsBlobsToL1 (26.73s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@Jason-W123 Jason-W123 mentioned this pull request Dec 26, 2025
@Jason-W123
Copy link
Collaborator Author

Reopened at #4176

@Jason-W123 Jason-W123 closed this Dec 26, 2025
@joshuacolvin0 joshuacolvin0 changed the title Fix: default EnableChunkedStore to false for datool dumpKeyset port: fix dumpkeyset (#4176) Dec 29, 2025
@joshuacolvin0
Copy link
Member

good to keep to backport #4176

@joshuacolvin0 joshuacolvin0 reopened this Dec 29, 2025
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshuacolvin0 joshuacolvin0 merged commit 215b55b into v3.9.x-release Dec 31, 2025
29 of 33 checks passed
@joshuacolvin0 joshuacolvin0 deleted the fix-datool-dumpkey branch December 31, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants