Skip to content

Conversation

@rauljordan
Copy link
Contributor

@rauljordan rauljordan commented Dec 11, 2025

This PR introduces recorder structs to record preimages for transactions and receipts needed for MEL validation.

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
4477 8 4469 0
View the top 3 failed tests by shortest run time
TestPrimaryToSecondaryFailover
Stack Traces | 5.440s run time
=== RUN   TestPrimaryToSecondaryFailover
=== PAUSE TestPrimaryToSecondaryFailover
=== CONT  TestPrimaryToSecondaryFailover
INFO [01-05|11:29:08.387] arbitrum websocket broadcast server is listening address=[::]:38983
    broadcastclients_test.go:206: Primary broadcaster listening on: [::]:38983
INFO [01-05|11:29:08.387] arbitrum websocket broadcast server is listening address=[::]:43033
    broadcastclients_test.go:207: Secondary broadcaster listening on: [::]:43033
    broadcastclients_test.go:230: Primary URL: ws://127.0.0.1:38983
    broadcastclients_test.go:231: Secondary URL: ws://127.0.0.1:43033
    broadcastclients_test.go:278: Phase 1: Sending messages from primary broadcaster
INFO [01-05|11:29:08.392] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:38983
INFO [01-05|11:29:08.393] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=0
INFO [01-05|11:29:08.394] arbitrum websocket broadcast server is listening address=[::]:44869
INFO [01-05|11:29:08.398] connecting to arbitrum inbox message broadcaster url=ws://127.0.0.1:44869
INFO [01-05|11:29:08.398] Feed connected                           feedServerVersion=2 chainId=1234 requestedSeqNum=0
    broadcastclients_test.go:308: Timed out waiting for message 5/5 from primary
--- FAIL: TestPrimaryToSecondaryFailover (5.44s)
TestVersion40
Stack Traces | 7.800s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestVersion40
�[90mposted new batch 16�[0;0m
    precompile_inclusion_test.go:94: goroutine 598292 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x4123e70, 0xc066127dc0}, {0x40e0ca0, 0xc11cba25a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc066127dc0, {0x40e0ca0, 0xc11cba25a0}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2058 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc066127dc0, 0x28, {0xc097e35df8, 0x5, 0x39?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion40(0xc066127dc0?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:71 +0x64b
        testing.tRunner(0xc066127dc0, 0x3d5f810)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion40 (7.80s)
TestRedisBatchPosterHandoff
Stack Traces | 25.850s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
github.com/ethereum/go-ethereum/rpc.(*callback).call(0xc25fac5620, {0x4408188, 0xc0e2e65590}, {0xc03a334920, 0xf}, {0xc138025da0, 0x4, 0x56e2d3?})
	/home/runner/work/nitro/nitro/go-ethereum/rpc/service.go:213 +0x397
github.com/ethereum/go-ethereum/rpc.(*handler).runMethod(0xc0da797110?, {0x4408188?, 0xc0e2e65590?}, 0xc07dd70460, 0x4?, {0xc138025da0?, 0x3a15f60?, 0xff010001f866e0?})
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:577 +0x7b
github.com/ethereum/go-ethereum/rpc.(*handler).handleCall(0xc1e91cd180, 0xc1b5d5c1b0, 0xc07dd70460)
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:519 +0x515
github.com/ethereum/go-ethereum/rpc.(*handler).handleCallMsg(0xc1e91cd180, 0xc1b5d5c1b0, 0xc07dd70460)
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:473 +0x4f7
github.com/ethereum/go-ethereum/rpc.(*handler).handleNonBatchCall(0xc1e91cd180, 0xc1b5d5c1b0, 0xc07dd70460)
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:299 +0x1dd
github.com/ethereum/go-ethereum/rpc.(*handler).handleMsg.func1.1(0x4408188?)
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:272 +0x31
github.com/ethereum/go-ethereum/rpc.(*handler).startCallProc.func1()
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:390 +0xc4
created by github.com/ethereum/go-ethereum/rpc.(*handler).startCallProc in goroutine 3146771
	/home/runner/work/nitro/nitro/go-ethereum/rpc/handler.go:386 +0xb5

    common_test.go:728: BuildL1 deployConfig: DeployBold=true, DeployReferenceDAContracts=false
    batch_poster_test.go:319: Batch poster BatchPoster2 failed with unexpected error: failed to acquire lock; either another batch poster posted a batch or this node fell behind, iter: 1
--- FAIL: TestRedisBatchPosterHandoff (25.85s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 0% with 204 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.27%. Comparing base (d216c3e) to head (063ce8e).

Additional details and impacted files
@@                    Coverage Diff                     @@
##           raul/mel-inbox-reading    #4130      +/-   ##
==========================================================
- Coverage                   34.77%   34.27%   -0.51%     
==========================================================
  Files                         465      468       +3     
  Lines                       56343    56547     +204     
==========================================================
- Hits                        19595    19382     -213     
- Misses                      33306    33761     +455     
+ Partials                     3442     3404      -38     

@ganeshvanahalli ganeshvanahalli marked this pull request as ready for review December 23, 2025 13:30
@ganeshvanahalli ganeshvanahalli changed the title [MEL] - Implement a Transaction Recorder for MEL Validation [MEL] - Implement a Transaction and Receipt Recorder for MEL Validation Dec 30, 2025
@ganeshvanahalli ganeshvanahalli self-requested a review December 30, 2025 12:17
@ganeshvanahalli ganeshvanahalli changed the base branch from raul/mel-inbox-reading to master January 5, 2026 16:16
@ganeshvanahalli ganeshvanahalli changed the base branch from master to raul/mel-inbox-reading January 5, 2026 16:16
@ganeshvanahalli ganeshvanahalli changed the title [MEL] - Implement a Transaction and Receipt Recorder for MEL Validation Implement a Transaction and Receipt Recorder for MEL Validation Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants